1792369 - sessionstore_valid.js and sessionstore_invalid.js are JSON files named like JS files that make eslint and searchfox sad and should be renamed

Status: NEW

(Firefox :: Session Restore, task)

Description

[Andrew Sutherland [:asuth] (he/him)]

I'm fixing some searchfox JS indexing logic and trying to make it so we can have actionable warning reports for JS and ran into sessionstore_valid.js and sessionstore_invalid.js as sources of warnings. It seems like our root .eslintignore already knows about them:

# Test files that are really json not js, and don't need to be linted.
browser/components/sessionstore/test/unit/data/sessionstore_valid.js
browser/components/sessionstore/test/unit/data/sessionstore_invalid.js

I have some other in-flight work that will ideally let searchfox eventually know not to care about .eslintignore-listed files, but it would be great to fix this issue as in the interim I'm putting a downgrade heuristic in place that will probably hit most of sessionstore while the workaround is present.

Comment 1

[Andrew Sutherland [:asuth] (he/him)]

Seems like there are some other files like https://searchfox.org/mozilla-central/source/testing/talos/talos/startup_test/sessionrestore/profile-manywindows/sessionstore.js that can also be a problem, and which a "sessionstore" downgrade heuristic helps address.