1792414 - <video width="0" height="0" style="height:auto"> should resolve to height=0

Status: ASSIGNED

(Core :: Layout: Images, Video, and HTML Frames, defect)

Description

[Dan Wolff]

Steps to reproduce:

Set the width and height of a video element using both attributes (width="0" height="0") and CSS (height: auto).

Actual results:

The resulting height is 150px.

Expected results:

Expected height is 0px.

Tested browser versions:

• [buggy] Firefox 107.0a1 (2022-09-25)
• [buggy] Firefox 105.0.1
• [ok] Firefox 104.0
• [ok] Firefox 91.13.0esr
• [ok] Chromium 105.0.5195.125

Comment 1

[Dan Wolff]

Attachment: video-height-bug.html

A gray square should be displayed.

In buggy browser versions, red-and-gray dashes are displayed.

Comment 2

[Dan Wolff]

Attachment: screenshots.png

Comment 3

[Ardelean Oana, Desktop QA [:oardelean]]

Hello, thank you for the bug report!

I managed to reproduce this issue on:

• Windows 11;
• macOS 12;
• Ubuntu 22;

Tested on:

• Firefox 106.0b9;
• Firefox 107.0a1;
• Firefox 105.0;

Setting the Product to Core and the Component to Layout: Images, Video and HTML frames. Please feel free to change these if you think there's a better fit. Thank you.
Setting the bug status as NEW.

Comment 4

[Ardelean Oana, Desktop QA [:oardelean]]

mozregression points to:

• last good: 2022-08-15
• first bad: 2022-08-16
• pushlog: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=048a4baf2c06d40a52a941a835d2525d4a8347ba&tochange=e1262ce83376f5e1109db8e91a115904ad41317f

Regressed by bug 1783069.

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1783069

:emilio, since you are the author of the regressor, bug 1783069, could you take a look? Also, could you set the severity field?

For more information, please visit auto_nag documentation.

Comment 6

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1792414 - Tweak video aspect-ratio behavior with degenerate ratio. r=boris,TYLin,Oriol,#layout

To preserve behavior on degenerate ratios like auto 0/0.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d2d7ad3741c8
Tweak video aspect-ratio behavior with degenerate ratio. r=Oriol

Comment 8

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/36380 for changes under testing/web-platform/tests

Comment 9

[Iulian Moraru]

Backed out for causing wpt failures on video-aspect-ratio.html.

Push with failures

Failure log

Backout link

[task 2022-10-10T19:49:08.985Z] 19:49:08     INFO - TEST-START | /html/semantics/selectors/pseudo-classes/indeterminate-radio.html
[task 2022-10-10T19:49:08.994Z] 19:49:08     INFO - Closing window eb9f4c0b-ac86-4306-8991-04efaa385085
[task 2022-10-10T19:49:09.056Z] 19:49:09     INFO - PID 12600 | [Child 13025, Main Thread] WARNING: '!CanHandleWith(aPresContext)', file /builds/worker/checkouts/gecko/dom/events/IMEStateManager.cpp:500
[task 2022-10-10T19:49:09.139Z] 19:49:09     INFO - PID 12600 | [Parent 12600, IPDL Background] WARNING: IPC Connection Error: [Parent][PBackgroundParent] RunMessage(msgname=PRemoteWorkerService::Msg___delete__) Channel closing: too late to send/recv, messages will be lost: file /builds/worker/checkouts/gecko/ipc/glue/MessageChannel.cpp:1883
[task 2022-10-10T19:49:09.147Z] 19:49:09     INFO - PID 12600 | [Parent 12600, Compositor] WARNING: IPC Connection Error: [Parent][PCompositorManagerParent] RunMessage(msgname=PCompositorBridge::Msg___delete__) Channel closing: too late to send/recv, messages will be lost: file /builds/worker/checkouts/gecko/ipc/glue/MessageChannel.cpp:1883
[task 2022-10-10T19:49:09.148Z] 19:49:09     INFO - PID 12600 | [Parent 12600, Compositor] WARNING: IPC Connection Error: [Parent][PImageBridgeParent] RunMessage(msgname=PImageBridge::Msg_WillClose) Channel closing: too late to send/recv, messages will be lost: file /builds/worker/checkouts/gecko/ipc/glue/MessageChannel.cpp:1883
[task 2022-10-10T19:49:09.159Z] 19:49:09     INFO - PID 12575 | ### XPCOM_MEM_BLOAT_LOG defined -- logging bloat/leaks to /tmp/tmp7ap70y4j/runtests_leaks_1191_rdd_pid13181.log
[task 2022-10-10T19:49:09.161Z] 19:49:09     INFO - PID 12575 | [13181, Main Thread] WARNING: XPCOM_MEM_BLOAT_LOG is set, disabling native allocations.: file /builds/worker/checkouts/gecko/tools/profiler/core/platform.cpp:339
[task 2022-10-10T19:49:09.198Z] 19:49:09     INFO - PID 12575 | [Parent 12575, Main Thread] WARNING: IPC message 'PContent::Msg_UpdateMediaCodecsSupported' discarded: actor cannot send: file /builds/worker/checkouts/gecko/ipc/glue/ProtocolUtils.cpp:504
[task 2022-10-10T19:49:09.219Z] 19:49:09     INFO - PID 12575 | ### XPCOM_MEM_BLOAT_LOG defined -- logging bloat/leaks to /tmp/tmp7ap70y4j/runtests_leaks_1191_utility_pid13183.log
[task 2022-10-10T19:49:09.220Z] 19:49:09     INFO - PID 12575 | [13183, Main Thread] WARNING: XPCOM_MEM_BLOAT_LOG is set, disabling native allocations.: file /builds/worker/checkouts/gecko/tools/profiler/core/platform.cpp:339
[task 2022-10-10T19:49:09.222Z] 19:49:09     INFO - PID 12600 | [Child 12797, Main Thread] WARNING: '!CanHandleWith(aPresContext)', file /builds/worker/checkouts/gecko/dom/events/IMEStateManager.cpp:500
[task 2022-10-10T19:49:09.282Z] 19:49:09     INFO - PID 12575 | [Parent 12575, Main Thread] WARNING: IPC message 'PContent::Msg_UpdateMediaCodecsSupported' discarded: actor cannot send: file /builds/worker/checkouts/gecko/ipc/glue/ProtocolUtils.cpp:504
[task 2022-10-10T19:49:09.418Z] 19:49:09     INFO - 
[task 2022-10-10T19:49:09.418Z] 19:49:09     INFO - TEST-UNEXPECTED-FAIL | /html/rendering/replaced-elements/attributes-for-embedded-content-and-images/video-aspect-ratio.html | Video width and height attributes are used to infer aspect-ratio - assert_approx_equals: expected 2.5 +/- 0.001 but got 2
[task 2022-10-10T19:49:09.418Z] 19:49:09     INFO - assert_ratio@http://web-platform.test:8000/html/rendering/replaced-elements/attributes-for-embedded-content-and-images/video-aspect-ratio.html:19:23
[task 2022-10-10T19:49:09.418Z] 19:49:09     INFO - @http://web-platform.test:8000/html/rendering/replaced-elements/attributes-for-embedded-content-and-images/video-aspect-ratio.html:42:17
[task 2022-10-10T19:49:09.419Z] 19:49:09     INFO - Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:2590:25
[task 2022-10-10T19:49:09.420Z] 19:49:09     INFO - promise_test/tests.promise_tests</<@http://web-platform.test:8000/resources/testharness.js:733:36
[task 2022-10-10T19:49:09.420Z] 19:49:09     INFO - promise_test/tests.promise_tests<@http://web-platform.test:8000/resources/testharness.js:732:20
[task 2022-10-10T19:49:09.420Z] 19:49:09     INFO - TEST-OK | /html/rendering/replaced-elements/attributes-for-embedded-content-and-images/video-aspect-ratio.html | took 1199ms
[task 2022-10-10T19:49:09.422Z] 19:49:09     INFO - PID 12575 | 1665431349421	Marionette	INFO	Stopped listening on port 37636
[task 2022-10-10T19:49:09.502Z] 19:49:09     INFO - PID 12575 | [Child 12730, Main Thread] WARNING: '!CanSend() || !mManager || !mManager->CanSend()', file /builds/worker/checkouts/gecko/dom/ipc/jsactor/JSWindowActorChild.cpp:44
[task 2022-10-10T19:49:09.504Z] 19:49:09     INFO - PID 12575 | [Child 12730, Main Thread] WARNING: '!CanSend() || !mManager || !mManager->CanSend()', file /builds/worker/checkouts/gecko/dom/ipc/jsactor/JSWindowActorChild.cpp:44
[task 2022-10-10T19:49:09.516Z] 19:49:09     INFO - PID 12575 | [Child 12730, Main Thread] WARNING: '!CanSend() || !mManager || !mManager->CanSend()', file /builds/worker/checkouts/gecko/dom/ipc/jsactor/JSWindowActorChild.cpp:44
[task 2022-10-10T19:49:09.524Z] 19:49:09     INFO - PID 12575 | [Child 12730, Main Thread] WARNING: '!CanSend() || !mManager || !mManager->CanSend()', file /builds/worker/checkouts/gecko/dom/ipc/jsactor/JSWindowActorChild.cpp:44
[task 2022-10-10T19:49:09.543Z] 19:49:09     INFO - PID 12575 | [Child 12730, Main Thread] WARNING: '!CanSend() || !mManager || !mManager->CanSend()', file /builds/worker/checkouts/gecko/dom/ipc/jsactor/JSWindowActorChild.cpp:44
[task 2022-10-10T19:49:09.550Z] 19:49:09     INFO - PID 12575 | [Child 12730, Main Thread] WARNING: '!CanSend() || !mManager || !mManager->CanSend()', file /builds/worker/checkouts/gecko/dom/ipc/jsactor/JSWindowActorChild.cpp:44
[task 2022-10-10T19:49:09.580Z] 19:49:09     INFO - PID 12575 | [Child 12730, Main Thread] WARNING: '!CanSend() || !mManager || !mManager->CanSend()', file /builds/worker/checkouts/gecko/dom/ipc/jsactor/JSWindowActorChild.cpp:44
[task 2022-10-10T19:49:09.666Z] 19:49:09     INFO - PID 12600 | [Child 13025, Main Thread] WARNING: Extra shutdown CC: 'i < NORMAL_SHUTDOWN_COLLECTIONS', file /builds/worker/checkouts/gecko/xpcom/base/nsCycleCollector.cpp:3387
[task 2022-10-10T19:49:09.688Z] 19:49:09     INFO - PID 12600 | [Child 13025, Main Thread] WARNING: NS_ENSURE_TRUE(InitStaticMembers()) failed: file /builds/worker/workspace/obj-build/dist/include/mozilla/Preferences.h:129
[task 2022-10-10T19:49:09.732Z] 19:49:09     INFO - PID 12600 | [Child 13025, Main Thread] WARNING: NS_ENSURE_TRUE(Preferences::InitStaticMembers()) failed: file /builds/worker/checkouts/gecko/modules/libpref/Preferences.cpp:4630
[task 2022-10-10T19:49:09.740Z] 19:49:09     INFO - PID 12575 | [Parent 12575, Main Thread] WARNING: '!CanHandleWith(aPresContext)', file /builds/worker/checkouts/gecko/dom/events/IMEStateManager.cpp:500
[task 2022-10-10T19:49:09.790Z] 19:49:09     INFO - PID 12575 | [Child 13005, Main Thread] WARNING: '!CanHandleWith(aPresContext)', file /builds/worker/checkouts/gecko/dom/events/IMEStateManager.cpp:500
[task 2022-10-10T19:49:09.792Z] 19:49:09     INFO - PID 12575 | [Parent 12575, Compositor] WARNING: Possibly dropping task posted to updater thread: file /builds/worker/checkouts/gecko/gfx/layers/apz/src/APZUpdater.cpp:371
[task 2022-10-10T19:49:09.814Z] 19:49:09     INFO - PID 12575 | [Parent 12575, IPDL Background] WARNING: IPC Connection Error: [Parent][PBackgroundParent] RunMessage(msgname=PRemoteWorkerService::Msg___delete__) Channel closing: too late to send/recv, messages will be lost: file /builds/worker/checkouts/gecko/ipc/glue/MessageChannel.cpp:1883
[task 2022-10-10T19:49:09.820Z] 19:49:09     INFO - PID 12575 | [Parent 12575, Compositor] WARNING: IPC Connection Error: [Parent][PImageBridgeParent] RunMessage(msgname=PImageBridge::Msg_WillClose) Channel closing: too late to send/recv, messages will be lost: file /builds/worker/checkouts/gecko/ipc/glue/MessageChannel.cpp:1883
[task 2022-10-10T19:49:09.852Z] 19:49:09     INFO - .
[task 2022-10-10T19:49:09.853Z] 19:49:09     INFO - TEST-OK | /html/semantics/selectors/pseudo-classes/indeterminate-radio.html | took 866ms
[task 2022-10-10T19:49:09.853Z] 19:49:09     INFO - TEST-START | /html/semantics/selectors/pseudo-classes/indeterminate-type-change.html

Comment 10

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream PR was closed without merging

Comment 11

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1783069

Comment 12

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Emilio, I'm assigning a severity to remove this bug from the triage list. Feel free to change the field to other value.