1792443 - The Pin Promo is still displayed in a Private Window if a user chooses to Pin a shortcut to the taskbar from the Existing users Onboarding modals

Status: NEW

(Firefox :: Messaging System, defect, P2)

Description

[Ciprian Muresan [:cmuresan], Ecosystem QA]

Attachment: vmplayer_7bTWsmsL96.gif

[Affected versions]:

• Firefox Beta 106.0b4 - Build ID: 20220925185751
• Firefox Nightly 107.0a1 - Build ID: 20220923093059

[Affected Platforms]:

• Windows 10
• Windows 7

[Prerequisites]:

• Have a clean new Firefox Beta 105 profile.

[Steps to reproduce]:

1. Open the Browser with the profile from prerequisites.
2. Update the browser to the latest version.
3. Skip the Onboarding modals until you reach the 2nd to last.
4. Click the Pin Private Browsing button.
5. Open a New Private Window and observe the page.

[Expected result]:

• The Focus Promo is displayed.

[Actual result]:

• The Pin Promo is displayed.

[Notes]:

• The issue is no longer reproducible after the browser is restarted.
• Attached a screen recording of the issue.

Comment 1

[Punam Dahiya [:pdahiya]]

We are caching doesAppNeedPrivatePin, cache refreshes every six hours or on browser restart causing pin promo to be shown when user opens new private window in the same Firefox instance right after pinning private browsing window from upgrade dialog.

https://searchfox.org/mozilla-central/rev/80e1bfa13c954e6450a13b3cc802d82773eba2e0/browser/components/newtab/lib/OnboardingMessageProvider.jsm#1051

https://searchfox.org/mozilla-central/rev/80e1bfa13c954e6450a13b3cc802d82773eba2e0/browser/components/newtab/lib/ASRouterTargeting.jsm#281

Comment 2

[Punam Dahiya [:pdahiya]]

privatePinPromo is the only usecase for doesAppNeedPrivatePin targeting, to fix the issue we can remove caching of doesAppNeedPrivatePin or reduce cache update interval, however this approach is not scalable if we have more use cases of doesAppNeedPrivatePin.

https://searchfox.org/mozilla-central/rev/80e1bfa13c954e6450a13b3cc802d82773eba2e0/browser/components/newtab/lib/ASRouterTargeting.jsm#281

Second option is to expose doesAppNeedPrivatePin method inside AboutPrivateBrowsingParent similar to shouldShowPromo and hide the message on client side if the check returns false.

https://searchfox.org/mozilla-central/source/browser/actors/AboutPrivateBrowsingParent.jsm#176
https://searchfox.org/mozilla-central/source/browser/components/privatebrowsing/content/aboutPrivateBrowsing.js#92

Considering both approaches can have slight load time increase due to extra check on opening about:privatebrowsing, NI product for feedback on priority of this fix , it might help to get some data points on how frequent this issue is seen by users.

Comment 3

[Vtay]

Let's wait to see how frequently this issue is seen by users.

Comment 4

[Vtay]

Seen by both @mlewis and @mbalfanz as well.

Comment 5

[Punam Dahiya [:pdahiya]]

Updating bug priority to track and fix in next release cycle