1792469 - Allow P3 color profile for linux builds

Status: RESOLVED WORKSFORME

(Core :: Graphics: Color Management, enhancement, P3)

Description

[CkExpress633]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:105.0) Gecko/20100101 Firefox/105.0

Steps to reproduce:

Currently only macos firefox builds support P3 color profiles. P3 gamut monitors are very common now and colors are oversaturated in firefox linux on these monitors.

The original issue is described here: https://github.com/saucecontrol/Compact-ICC-Profiles

"The P3 color space requires a negative Z value for the red primary when adapted to the profile illuminant, which is not allowed according the the ICC spec. While some software will handle the negative value correctly, it may cause issues with software that adheres strictly to the ICC specs, including popular web browsers. Chrome and Firefox recently relaxed those restrictions, but only on Apple platforms."

This was patched years ago for Mac builds (https://bugzilla.mozilla.org/show_bug.cgi?id=1250461)

Actual results:

Colors are oversaturated

Expected results:

Allow P3 icc profiles!

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Toolkit::Startup and Profile System' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:aosmond, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 3

[CkExpress633]

I also want to note many LG monitors (and other manufactures) cover 95%-98% DCI-P3 gamut. So the OS generated icc profile would be automatically invalid for a significant number firefox users.

Comment 4

[Andrew Osmond [:aosmond] (he/him)]

We support P3 on OSX because we are relying on the platform support in the display pipeline, so it was feasible to ship on its own. We have more machinery needed to be put in place to support it on Linux.

Comment 5

[CkExpress633]

(In reply to Andrew Osmond [:aosmond] (he/him) from comment #4)

We support P3 on OSX because we are relying on the platform support in the display pipeline, so it was feasible to ship on its own. We have more machinery needed to be put in place to support it on Linux.

from my limited testing, when i edited iccread.rs to accept negative values for the transform matrix using the existing function for macos, everything works great and colors are corrected.

Comment 6

[Jeff Muizelaar [:jrmuizel]]

This should be fixed by bug 1799391