179250 - Pressing Shift-TAB in composer should not insert a tab into the text

Status: VERIFIED DUPLICATE of bug 87321

(MailNews Core :: Composition, defect)

Description

[Ere Maijala (slow)]

Using trunk build 2002110808 on WinXP. Pressing Shift-TAB in message composer to
get back to the subject field inserts a TAB to the message. Focus moves
correctly to subject field, but the TAB should not be inserted.

Comment 1

[Jean-Francois Ducarroz]

-->varada

Comment 2

[Mike Gebis]

I think that this bug is related to bug 84454.

I can also confirm that this bug still exists Win2k 2002120508.

Comment 3

[Bob Lockie]

Also in Linux.
Mozilla 1.3a
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.3a) Gecko/20021208

Comment 4

[(not reading, please use [e-mail] instead)]

taking all of varada's bugs.

Comment 5

[Serge Gautherie (:sgautherie)]

[Mozilla/5.0 (Windows; U; Win95; en-US; rv:1.3a) Gecko/20021212]

Same bug on my Win95.

Workaround: obviously, go back to the text and delete the inserted tab :-<

PS: OS should be changed from WinXP to All, based on comment 3. (I don't have
enough rights :-()

Comment 6

[Brant Gurganus]

*** Bug 186364 has been marked as a duplicate of this bug. ***

Comment 7

[R.K.Aa.]

*** Bug 189119 has been marked as a duplicate of this bug. ***

Comment 8

[Myk Melez [:myk] [@mykmelez]]

Attachment: patch to fix problem (makes editorKeyPress a capturing handler)

Here's a simple patch that fixes the problem by making editorKeyPress a
capturing handler so it can intercept shift-tabs before the editor widget gets
them.

Comment 9

[[e-mail]]

Attachment: Attack the problem from the other end

I think it would be preferable to
a) Stop Shift+Tab from ever inserting tabs, and while I'm there
b) Stop Shift+Tab from focussing the subject if I'm outdenting

Comment 10

[Kathleen :Brade]

Comment on attachment 112061 [details] [diff] [review]
Attack the problem from the other end

calling StopPropagation seems wrong.  It is preferable to call
aKeyEvent->PreventDefault(); but I think that is already being called.

Comment 11

[Kathleen :Brade]

I am not in favor of either of the strategies used by either of these patches. 
I expect that the problem lies somewhere else.  Somewhere we should be calling
"event->GetPreventDefault" where we aren't.  I don't know enough about the mail
compose widget to know if it is doing the right thing or if focus switching is
the culprit or ?

Comment 12

[Kathleen :Brade]

this is a duplicate bug...

*** This bug has been marked as a duplicate of 87321 ***

Comment 13

[Serge Gautherie (:sgautherie)]

Re to comment 12:

I don't mean to bother you, but: Are you sure ? (may be you say so from a code
level ?)
Because at a user level only, the two descriptions describe different
behaviours/cases.

Comment 14

[Kathleen :Brade]

The only difference is how the editor handles the tab.  The core issue is that
the editor is handling the tab in addition to focus being adjusted.

Comment 15

[[e-mail]]

OK, so should we prevent Shift+TAB from inserting a tab at all times anyway?

Comment 16

[Kathleen :Brade]

Shift-tab should not insert a tab character but the editor does care about
shift-tab in some cases (editing lists, editing tables) so Composer should not
ignore all shift-tab key events.

Comment 17

[Vedran Miletic]

v