1792513 - QuickActions: Shrinked Buttons expand and wrap into a new line when activating a search engine

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect)

Description

[Mehmet]

Attachment: Bildschirmvideo aufnehmen 2022-09-27 um 08.15.18.mov

Nightly 107.0a1 (2022-09-25) (64-Bit)
macOS

1.) Make the window smaller
2.) Focus the Address Bar
3.) Notice that the Quickaction buttons are shrinked to a smaller size without wrapping the line.
4.) Press the arrow down key on the keyboard until you reach a search engine, e.g. Amazon

Actual: Quickaction buttons expand and wrap into new lines

Expected: Quickaction buttons should stay as they are.

Not sure if this is intentional, but maybe you could have a look at this.

A screencast is attached.

Thanks :)

Comment 1

[Mehmet]

Attachment: Bildschirmvideo aufnehmen 2022-09-27 um 08.25.28.mov

Comment 2

[Daisuke Akatsuka (:daisuke)]

Hi Dale.
It seems we are setting the style explicitly, is this expected behavior??
https://searchfox.org/mozilla-central/rev/d45dd05bf412e7468b3770a52519e9d546d6325c/browser/themes/shared/urlbar-dynamic-results.css#158-160

Comment 3

[Dale Harvey (:daleharvey)]

Not expected, the flex-wrap is set for when the user enters the Actions search mode otherwise they wouldnt be able to see all of the actions, typically this is when the user has clicked the actions search mode and the urlbar is otherwise empty. In this case (which I didn't realise) when the user scrolls through the one off actions buttons it enters the search mode. We need to do something smarter than the current #urlbar[searchmode] to only wrap when we fully enter the actions mode

Comment 4

[Daisuke Akatsuka (:daisuke)]

Ah, I see. Thanks!

Comment 5

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 1792513: Do not show full list of Quick Actions while scrolling one off buttons.

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:adw, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5c1df6520ce6
Do not show full list of Quick Actions while scrolling one off buttons. r=daleharvey,adw

Comment 8

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/5c1df6520ce6

Comment 9

[Petruta Horea [:phorea], Desktop QA]

Verified as fixed using Firefox 107 beta 3 under Win 10 64-bit, Ubuntu 22.04 and Mac OSX 10.14; filled a small follow-up, bug 1796805.