1792615 - Run rustfmt on style components under servo

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, task)

Description

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

+++ This bug was initially created as a clone of Bug #1741990 +++

We run rustfmt for style components 10 months ago in Bug 1741990. Let's run it again.

Comment 1

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

Attachment: Bug 1792615 - Run "cargo +nightly fmt" for style components in servo. r?#style

The directories changed:

• servo/components/selectors/
• servo/components/style/
• servo/components/style_derive/
• servo/ports/geckolib/

mozilla-central is at
https://hg.mozilla.org/mozilla-central/rev/d1ae84015c22f2034435b47194fdced878072035

My nightly rust is 1.66.0-nightly (8b705839c 2022-09-26).

Comment 2

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

I enable rustfmt on-save in my editor, so it's a bit annoying to see unrelated changes when changing servo/.

Emilio, do you know if we could enable rustfmt lint in phabricator for Rust code (similar to clang-format lint for C++).

Comment 3

[Emilio Cobos Álvarez (:emilio)]

I think the main issue is that servo is formatted with unstable options, and that wasn't quite easily supported. I managed to get binop_separator stabilized, but then apparently it had to be redone. I sent https://github.com/rust-lang/rustfmt/pull/5549 re-stabilizing again.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fe028fc9f38e
Run "cargo +nightly fmt" for style components in servo. r=emilio

Comment 5

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/fe028fc9f38e