Run rustfmt on style components under servo
Categories
(Core :: CSS Parsing and Computation, task)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox107 | --- | fixed |
People
(Reporter: TYLin, Assigned: TYLin)
References
Details
Attachments
(1 file)
+++ This bug was initially created as a clone of Bug #1741990 +++
We run rustfmt for style components 10 months ago in Bug 1741990. Let's run it again.
|
Assignee | |
Comment 1•2 years ago
|
||
The directories changed:
- servo/components/selectors/
- servo/components/style/
- servo/components/style_derive/
- servo/ports/geckolib/
mozilla-central is at
https://hg.mozilla.org/mozilla-central/rev/d1ae84015c22f2034435b47194fdced878072035
My nightly rust is 1.66.0-nightly (8b705839c 2022-09-26).
|
|
Assignee | |
Comment 2•2 years ago
|
||
I enable rustfmt on-save in my editor, so it's a bit annoying to see unrelated changes when changing servo/.
Emilio, do you know if we could enable rustfmt lint in phabricator for Rust code (similar to clang-format lint for C++).
|
||
Comment 3•2 years ago
|
||
I think the main issue is that servo is formatted with unstable options, and that wasn't quite easily supported. I managed to get binop_separator stabilized, but then apparently it had to be redone. I sent https://github.com/rust-lang/rustfmt/pull/5549 re-stabilizing again.
Pushed by tlin@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/fe028fc9f38e Run "cargo +nightly fmt" for style components in servo. r=emilio
|
||
Comment 5•2 years ago
|
||
| bugherder | ||
Description
•