1792627 - Add irregexp to Updatebot

Status: RESOLVED FIXED

(Developer Infrastructure :: Mach Vendor & Updatebot, enhancement)

Description

[Tom Ritter [:tjr]]

Looking at import-irregexp.py it seems like we could turn that into moz.yaml based steps, but it'd probably be verbose and less straightforward to maintain than keeping the python script.

We'll need to figure out who is going to be owner to get the bugs assigned, and how often we want to try to update it.

Comment 1

[Tom Ritter [:tjr]]

It appears that the upstream repo for this (v8) is... quite large. So we'll probably want to pre-seed the repo into the Updatebot image like we do for pdf.js.

Comment 2

[Tom Ritter [:tjr]]

So there's a wrinkle here: irregexp is part of v8 (which is large). Do we want to implement it as a github flavor (in which case we will always try to update it and most will be spurious) or do we want to implement it as an individual-files flavor (which will also result in the same large number of spurious updates). The difference basically comes down to "Should we git pull all the time; or should we wget all the individual files all the time?" This is a bit of 'how the sausage is made' that's not really relevant to the recipients of this work. I think that while the download-each-file approach might be more efficient (and lend itself to future improvements where we don't actually have to download each file) - we should lean towards something more concise that's likely to be more developer-friendly.

Comment 3

[Tom Ritter [:tjr]]

Attachment: Bug 1792627: Use mach vendor-based updating for irregexp r?iain

Comment 4

[Tom Ritter [:tjr]]

Attachment: Bug 1792627: Add an updatebot job for irregexp r?iain

Depends on D158289

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

There are some r+ patches which didn't land and no activity in this bug for 2 weeks.
:tjr, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit auto_nag documentation.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/af2eaf26c980
Use mach vendor-based updating for irregexp r=iain
https://hg.mozilla.org/integration/autoland/rev/e7b116f16406
Add an updatebot job for irregexp r=iain

Comment 7

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/af2eaf26c980
https://hg.mozilla.org/mozilla-central/rev/e7b116f16406