1792676 - [wayland] KeyboardEvent modifiers true on keyup instead of keydown

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect, P3)

Description

[lilydjwg]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:106.0) Gecko/20100101 Firefox/106.0

Steps to reproduce:

1. open https://w3c.github.io/uievents/tools/key-event-viewer.html
2. press Alt key once

Actual results:

For the keydown event, getModifierState is -, alt is false, and for keyup getModifierState is Alt and alt is true.

Expected results:

For the keydown event, getModifierState is Alt, alt is true, and for keyup getModifierState is - and alt is false.

On XWayland this issue doesn't happen. With Google Chrome this issue also doesn't happen.

I'm running Wayfire (wlroots-based wayland compositor) on Arch Linux, with Firefox Nightly.

Comment 1

[lilydjwg]

I'm having issues with a cloud game site on which holding Alt key does nothing. With XWayland it works as expected.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Core::Widget: Gtk' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 3

[lilydjwg]

I believe this is indeed the issue I have with the website, because when I press my other Alt key, the latter event's modifier attributes are expected, and it works for the website. This is an awkward workaround for me as holding two Alt keys for some time will trigger my keyboard to reset its key maps. I have to reach for my laptop's builtin keyboard.

I believe it's caused by the key-press-event from GTK only has the modifier state for the previous key. Firefox has handled this only for X11: https://searchfox.org/mozilla-central/source/widget/gtk/nsGtkKeyUtils.cpp#1787.

Comment 4

[lilydjwg]

when I press my other Alt key

To clarify, I mean to hold one Alt key, and press the other one, because the modifier state is only on the latter keydown event.

Comment 6

[Kestrel]

Attachment: Comparison of modifier keypress events with Chromium

Comment 7

[Martin Stránský [:stransky] (ni? me)]

I see that on XWayland too. It may depend which events are queued and if we can detect modifier key in queue.

Comment 8

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1792676 [Wayland] Set modifiers according to key press/release r?emilio

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e491a43ef9e8
[Wayland] Set modifiers according to key press/release r=emilio

Comment 10

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/e491a43ef9e8