1792678 - WebTransport and HTTP redirects

Status: RESOLVED FIXED

(Core :: Networking: HTTP, task, P3)

Description

[Dragana Damjanovic [:dragana]]

The current implementation (bug 1790398) supports redirects and it will follow them, although the tests are still outstanding.

The spec is not concrete yet and there was some discussion on the IETF.

This bug should make sure we add tests for redirects and also add a pref to control the behavior and when the decision is made on IETF disable or enable redirects.

Comment 1

[Sunil Mayya]

Kershaw I would like to confirm my understanding of the bug and my approach to solve it. Please let me know if I have missed something.

Changes for this bug includes 2 parts
Part 1 -

• Add a preference for controlling redirects
• The pref can be checked here

Part 2

• Add a test case for redirect similar to test_connect_wt , replacing success in the path with redirect.
• Ensure the redirect is handled here
• Currently we only support 200 and 404 as responses to a web transport request for accepting/rejecting the request. We need to extend this to support redirects and other responses. The following functions will be affected
• response
• webtransport_session_accept

Comment 2

[Kershaw Chang [:kershaw]]

(In reply to Sunil Mayya from comment #1)

Kershaw I would like to confirm my understanding of the bug and my approach to solve it. Please let me know if I have missed something.

Thanks Sunil! These all look good to me.

Changes for this bug includes 2 parts
Part 1 -

• Add a preference for controlling redirects
• The pref can be checked here

Yes, I think this is a correct place.

Part 2

• Add a test case for redirect similar to test_connect_wt , replacing success in the path with redirect.
• Ensure the redirect is handled here
• Currently we only support 200 and 404 as responses to a web transport request for accepting/rejecting the request. We need to extend this to support redirects and other responses. The following functions will be affected
• response
• webtransport_session_accept

According to the discussion here, it seems they inclined to not support redirection. But even so, we still need to write a test for this.
I think modifying response and webtransport_session_accept to support returning 3xx response (also a location header) would be the first step.
To do this, you may want to create a neqo issue and submit a PR.
Thanks!

Comment 3

[Sunil Mayya]

Neqo issue created to track support of 3XX response header here. Changes are verified locally and PR will be submitted soon.

Comment 4

[Sunil Mayya]

Attachment: Bug 1792678 - add webtransport redirect preference. r=#necko

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/90a70d71e836
add webtransport redirect preference. r=necko-reviewers,kershaw

Comment 6

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/90a70d71e836