Closed Bug 1792692 Opened 3 years ago Closed 3 years ago

Treat empty names as invalid in web platform tests for file system move

Categories

(Core :: DOM: File, defect, P3)

defect

Tracking

()

RESOLVED FIXED
107 Branch
Tracking Status
firefox107 --- fixed

People

(Reporter: jari, Assigned: jari)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

In the web platform tests for OPFS directory handle moves, leaving the target name empty is not an error but equivalent to keeping the original name of the file system entry whenever the destination folder is specified. According to the discussion at the spefication pipeline https://github.com/whatwg/fs/pull/10 , all parties agree that throwing an error is preferred. In this bug, we change the tests to reflect this behavior.

This feature is tested by tests in testing/web-platform/tests/file-system-access/sandboxed_FileSystemDirectoryHandle-move.https.any.js

Summary: Keep original when parent is given but new name empty for FileSystemHandle::move → Keep name when parent is given but new name empty for FileSystemHandle::move
Blocks: 1792707
Attachment #9296485 - Attachment description: Bug 1792692 - Keep name when parent is given but new name empty for FileSystemHandle::move. r=#dom-storage → Bug 1792692 - Treat empty names as invalid in file system move tests. r=#dom-storage
Summary: Keep name when parent is given but new name empty for FileSystemHandle::move → Treat empty names as invalid in web platform tests for file system move
Pushed by jjalkanen@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/c6aca3bac984 Treat empty names as invalid in file system move tests. r=dom-storage-reviewers,jesup
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/36360 for changes under testing/web-platform/tests
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 107 Branch
Upstream PR merged by moz-wptsync-bot
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: