1792751 - ./mach esmify fails if the path contains a dash

Status: RESOLVED FIXED

(Core :: General, defect)

Description

[Julian Descottes [:jdescottes]]

STRs:

• run ./mach esmify --convert remote/webdriver-bidi/

ER:
JSMs should be converted

AR:
No JSM found

I am using hg 6.2, and it seems that remote/webdriver-bidi/ cannot be used as glob syntax. Testing individual commands such as hg files set:glob:remote/webdriver-bidi/**/*.jsm does not return any file, whereas hg files set:glob:remote/webdriver?bidi/**/*.jsm will return all files.

Was not able to escape the - in any way, and in anycase I think esmify still expects the argument to be an actual path, so this might need a fix in the script anyway.

Comment 1

[Kris Maglione [:kmag]]

I'm not really sure what component this belongs in, but build metadata says esmify belongs to Core :: General, so...

Comment 2

[Tooru Fujisawa [:arai]]

hg files 'set:glob:remote/webdriver-bidi/**/*.jsm' doesn't return any file, but hg files 'set:glob:"remote/webdriver-bidi/**/*.jsm"' returns the file list.
So, apparently the pattern needs extra quote.

I'll fix the esmify command to quote the pattern.

Comment 3

[Tooru Fujisawa [:arai]]

Attachment: Bug 1792751 - Quote the mercurial glob pattern in mach esmify command. r?yulia!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/afff9a173a44
Quote the mercurial glob pattern in mach esmify command. r=yulia

Comment 5

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/afff9a173a44