Closed Bug 1792980 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 36190 - Transform timeouts in errors in COOP iframe WPTs.

Categories

(Core :: DOM: Core & HTML, task, P4)

Product:
Core
Component:
DOM: Core & HTML
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
108 Branch
Tracking Flags:
Tracking Status
firefox108 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 36190 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/36190
Details from upstream follow.

Arthur Hemery <ahemery@chromium.org> wrote:

Transform timeouts in errors in COOP iframe WPTs.

When we got an unexpected no-opener behavior, we skipped verifying that
the popup handle was not null. This resulted in a javascript syntax
error (property access into null) and a timeout. Add an extra check
before so that we simply fail a check instead.

Bug: 1318373
Change-Id: Idd0f309d692c205c96a30e28467a13a8c42edf60
Reviewed-on: https://chromium-review.googlesource.com/3929045
WPT-Export-Revision: 5aeb8adc44201ee20443dd200ad0b67adc0cd27f

Component: web-platform-tests → DOM: Core & HTML
Product: Testing → Core
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]

CI Results

Ran 10 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 55 tests and 6 subtests

Status Summary

Firefox

OK : 48[Gecko-android-em-7.0-x86_64-qr-debug-isolated-process-geckoview] 54[Gecko-android-em-7.0-x86_64-qr-debug-geckoview] 55[Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-32-2004-qr-debug, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt, GitHub]
PASS : 279
FAIL : 18
TIMEOUT: 1[Gecko-android-em-7.0-x86_64-qr-debug-geckoview] 7[Gecko-android-em-7.0-x86_64-qr-debug-isolated-process-geckoview]

Chrome

OK : 42
PASS : 215
FAIL : 13
ERROR : 13

Safari

OK : 15
PASS : 63
CRASH : 40
FAIL : 18

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

  • /html/cross-origin-opener-policy/iframe-popup-same-origin-allow-popups-to-same-origin-allow-popups.https.html?7-8 [wpt.fyi]: OK [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-32-2004-qr-debug, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt, GitHub], TIMEOUT [Gecko-android-em-7.0-x86_64-qr-debug-isolated-process-geckoview] (Chrome: OK, Safari: CRASH)
  • /html/cross-origin-opener-policy/iframe-popup-same-origin-allow-popups-to-same-origin.https.html?7-8 [wpt.fyi]: OK [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-32-2004-qr-debug, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt, GitHub], TIMEOUT [Gecko-android-em-7.0-x86_64-qr-debug-isolated-process-geckoview] (Chrome: OK, Safari: CRASH)
  • /html/cross-origin-opener-policy/iframe-popup-same-origin-allow-popups-to-unsafe-none.https.html?5-6 [wpt.fyi]: OK [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-32-2004-qr-debug, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt, GitHub], TIMEOUT [Gecko-android-em-7.0-x86_64-qr-debug-isolated-process-geckoview] (Chrome: OK, Safari: CRASH)
  • /html/cross-origin-opener-policy/iframe-popup-same-origin-to-same-origin.https.html?3-4 [wpt.fyi]: OK [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-isolated-process-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-32-2004-qr-debug, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt, GitHub], TIMEOUT [Gecko-android-em-7.0-x86_64-qr-debug-geckoview] (Chrome: ERROR, Safari: CRASH)
  • /html/cross-origin-opener-policy/iframe-popup-same-origin-to-unsafe-none.https.html?5-6 [wpt.fyi]: OK [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-32-2004-qr-debug, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt, GitHub], TIMEOUT [Gecko-android-em-7.0-x86_64-qr-debug-isolated-process-geckoview] (Chrome: ERROR, Safari: CRASH)
  • /html/cross-origin-opener-policy/iframe-popup-unsafe-none-to-same-origin.https.html?9-last [wpt.fyi]: OK [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-32-2004-qr-debug, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt, GitHub], TIMEOUT [Gecko-android-em-7.0-x86_64-qr-debug-isolated-process-geckoview] (Chrome: OK, Safari: CRASH)
  • /html/cross-origin-opener-policy/tentative/restrict-properties/iframe-popup-to-un.https.html?9-last [wpt.fyi]
    • COOP: restrict-properties to popup COOP: unsafe-none via an iframe, with cross origin iframe, cross origin popup with window_open: FAIL (Safari: FAIL)
  • /html/cross-origin-opener-policy/tentative/restrict-properties/iframe-popup-to-un.https.html?3-4 [wpt.fyi]: OK [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-32-2004-qr-debug, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt, GitHub], TIMEOUT [Gecko-android-em-7.0-x86_64-qr-debug-isolated-process-geckoview] (Chrome: OK, Safari: OK)
    • COOP: restrict-properties to popup COOP: unsafe-none via an iframe, with cross origin iframe, same origin popup with window_open: FAIL (Chrome: FAIL, Safari: FAIL)
    • COOP: restrict-properties to popup COOP: unsafe-none via an iframe, with same origin iframe, same site popup with window_open: FAIL (Chrome: FAIL, Safari: FAIL)
  • /html/cross-origin-opener-policy/tentative/restrict-properties/iframe-popup-to-un.https.html?5-6 [wpt.fyi]
    • COOP: restrict-properties to popup COOP: unsafe-none via an iframe, with same site iframe, same site popup with window_open: FAIL (Chrome: FAIL, Safari: FAIL)
    • COOP: restrict-properties to popup COOP: unsafe-none via an iframe, with cross origin iframe, same site popup with window_open: FAIL (Chrome: FAIL, Safari: FAIL)
  • /html/cross-origin-opener-policy/tentative/restrict-properties/iframe-popup-to-un.https.html?7-8 [wpt.fyi]
    • COOP: restrict-properties to popup COOP: unsafe-none via an iframe, with same origin iframe, cross origin popup with window_open: FAIL (Safari: FAIL)
    • COOP: restrict-properties to popup COOP: unsafe-none via an iframe, with same site iframe, cross origin popup with window_open: FAIL (Safari: FAIL)
  • /html/cross-origin-opener-policy/tentative/restrict-properties/iframe-popup-to-un.https.html?1-2 [wpt.fyi]: OK [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-32-2004-qr-debug, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt, GitHub], TIMEOUT [Gecko-android-em-7.0-x86_64-qr-debug-isolated-process-geckoview] (Chrome: ERROR, Safari: OK)
    • COOP: restrict-properties to popup COOP: unsafe-none via an iframe, with same origin iframe, same origin popup with window_open: FAIL (Safari: FAIL)
    • COOP: restrict-properties to popup COOP: unsafe-none via an iframe, with same site iframe, same origin popup with window_open: FAIL (Safari: FAIL)
  • /html/cross-origin-opener-policy/tentative/restrict-properties/iframe-popup.https.html?7-8 [wpt.fyi]
    • COOP: restrict-properties to popup COOP: restrict-properties via an iframe, with same origin iframe, cross origin popup with window_open: FAIL (Chrome: FAIL, Safari: FAIL)
    • COOP: restrict-properties to popup COOP: restrict-properties via an iframe, with same site iframe, cross origin popup with window_open: FAIL (Chrome: FAIL, Safari: FAIL)
  • /html/cross-origin-opener-policy/tentative/restrict-properties/iframe-popup.https.html?1-2 [wpt.fyi]
    • COOP: restrict-properties to popup COOP: restrict-properties via an iframe, with same origin iframe, same origin popup with window_open: FAIL (Chrome: FAIL, Safari: FAIL)
    • COOP: restrict-properties to popup COOP: restrict-properties via an iframe, with same site iframe, same origin popup with window_open: FAIL (Chrome: FAIL, Safari: FAIL)
  • /html/cross-origin-opener-policy/tentative/restrict-properties/iframe-popup.https.html?5-6 [wpt.fyi]
    • COOP: restrict-properties to popup COOP: restrict-properties via an iframe, with same site iframe, same site popup with window_open: FAIL (Chrome: FAIL, Safari: FAIL)
    • COOP: restrict-properties to popup COOP: restrict-properties via an iframe, with cross origin iframe, same site popup with window_open: FAIL (Chrome: FAIL, Safari: FAIL)
  • /html/cross-origin-opener-policy/tentative/restrict-properties/iframe-popup.https.html?9-last [wpt.fyi]
    • COOP: restrict-properties to popup COOP: restrict-properties via an iframe, with cross origin iframe, cross origin popup with window_open: FAIL (Chrome: FAIL, Safari: FAIL)
  • /html/cross-origin-opener-policy/tentative/restrict-properties/iframe-popup.https.html?3-4 [wpt.fyi]
    • COOP: restrict-properties to popup COOP: restrict-properties via an iframe, with cross origin iframe, same origin popup with window_open: FAIL (Chrome: FAIL, Safari: FAIL)
    • COOP: restrict-properties to popup COOP: restrict-properties via an iframe, with same origin iframe, same site popup with window_open: FAIL (Chrome: FAIL, Safari: FAIL)
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/c28c9c677128 [wpt PR 36190] - Transform timeouts in errors in COOP iframe WPTs., a=testonly https://hg.mozilla.org/integration/autoland/rev/9cc3bb4186a5 [wpt PR 36190] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/c28c9c677128
https://hg.mozilla.org/mozilla-central/rev/9cc3bb4186a5

Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox108: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 108 Branch
You need to log in before you can comment on or make changes to this bug.