Closed Bug 1792992 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 35710 - [CompositeClipPathAnimations] Ensure fragmented layouts fall back to main thread

Categories

(Core :: Web Painting, task, P4)

task

Tracking

()

RESOLVED FIXED
107 Branch
Tracking Status
firefox107 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 35710 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/35710
Details from upstream follow.

Claire Chambers <clchambers@microsoft.com> wrote:

[CompositeClipPathAnimations] Ensure fragmented layouts fall back to main thread

Animations on fragmented layouts are defined as not being
compositable, however, due to an omission in HasCompositeClipPathAnimation, clip paths would use paint worklet
based clip even if they were not compositable.

Because the decision to composite a clip path animation occurs in
the pre-paint phase (as it is tied to the decision whether or not
to paint with a mask-based clip), an additional variable is needed
to determine whether an animation is compositable or not, as the
fragmentation of a layout object is not visible from just the layout
object before pre paint has finished.

Bug: 1359514
Change-Id: I9d76518f00e3cc50b968ab2b0d67ecfdf6771fb1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3846017
Reviewed-by: Olga Gerchikov \<gerchiko@microsoft.com>
Reviewed-by: Robert Flack \<flackr@chromium.org>
Commit-Queue: Claire Chambers \<clchambers@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#1051088}

Component: web-platform-tests → Web Painting
Product: Testing → Core

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

PASS: 1

Chrome

PASS: 1

Safari

PASS: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Severity: -- → N/A
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/1487477d564b [wpt PR 35710] - [CompositeClipPathAnimations] Ensure fragmented layouts fall back to main thread, a=testonly
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 107 Branch
You need to log in before you can comment on or make changes to this bug.