1792995 - Using Fathom to recognize credit card name field

Status: RESOLVED FIXED

(Toolkit :: Form Autofill, task, P2)

Description

[Dimi Lee [:dimi]]

We use fathom to recognize credit card number field in Bug 1759418. We can also do the same to detect credit card name field.

Comment 1

[Dimi Lee [:dimi]]

Attachment: Bug 1792995 - P1. Add a preference to determine what types of credit card fields are checked by fathom. r=sgalich

Comment 2

[Dimi Lee [:dimi]]

Attachment: Bug 1792995 - P2. Add a 'fathom' prefix to formautofill fathom related preferences r=sgalich

Depends on D158646

Comment 3

[Dimi Lee [:dimi]]

Attachment: Bug 1792995 - P3. Enable using fathom to identify cc-name field. r=sgalich

This patch change the behavior of the following two cases:

1. Before this patch, if a form contains a cc-name field and a cc-exp
   field that are both identified by regex-based heuristic, we consider
   it a valid cc section in Nighty build.

   After this patch, the above case only consider a valud cc section when the cc-name field is
   identified by fathom. This applys to all builds.

2. Before this patch, a form contains only a cc-name field without
   autocomplete attribute is never considered a valid cc section.

   After this patch, a form contains only a cc-name field is considered
   a valid cc section when fathom is confident

Depends on D158647

Comment 4

[Dimi Lee [:dimi]]

Attachment: Bug 1792995 - P2. Add a 'fathom' prefix to formautofill fathom related preferences r=sgalich

Depends on D158646

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0039108405c2
P1. Add a preference to determine what types of credit card fields are checked by fathom. r=sgalich
https://hg.mozilla.org/integration/autoland/rev/d74fda910a24
P2. Add a 'fathom' prefix to formautofill fathom related preferences r=sgalich
https://hg.mozilla.org/integration/autoland/rev/1a57d5dc1cf5
P3. Enable using fathom to identify cc-name field. r=sgalich

Comment 6

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/0039108405c2
https://hg.mozilla.org/mozilla-central/rev/d74fda910a24
https://hg.mozilla.org/mozilla-central/rev/1a57d5dc1cf5