1793021 - [wpt-sync] Sync PR 36100 - [Private Network Access] Fix test cases in service-worker-update.https.window.js

Status: RESOLVED FIXED

(Core :: DOM: Networking, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 36100 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/36100
Details from upstream follow.

Jonathan Hao <[e-mail]> wrote:

[Private Network Access] Fix test cases in service-worker-update.https.window.js

(This is a reland of https://crrev.com/c/3878345. The CL itself has no
problem. It was only reverted so another CL can be reverted cleanly.)

The two failing test cases failed not because of PNA checks, but because
the browser sends a Service-Worker header which the server didn't explicitly
allowed. Using serviceWorkerSuccess will make a query that would return
"Access-Control-Allow-Headers: Service-Worker". See also [1]

[1] https://chromium-review.googlesource.com/c/chromium/src/+/3858436

Bug: 1239551
Change-Id: I09c8016e7de39d2e4a8bc1f9b887181d29773096
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3921642
Auto-Submit: Jonathan Hao \<[e-mail]>
Commit-Queue: Titouan Rigoudy \<[e-mail]>
Commit-Queue: Jonathan Hao \<[e-mail]>
Reviewed-by: Titouan Rigoudy \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1051862}

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=4ac657abc528c5581224237c420b9bd2d2261d29

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 10 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 5 subtests

Status Summary

Firefox

OK : 1
PASS: 1
FAIL: 4

Chrome

OK : 1
PASS: 1
FAIL: 4

Safari

OK : 1
PASS: 1
FAIL: 4

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /fetch/private-network-access/service-worker-update.https.window.html [wpt.fyi]
  • update public to local: failed preflight.: FAIL (Chrome: FAIL, Safari: FAIL)
  • update public to local: success.: FAIL (Chrome: FAIL, Safari: FAIL)
  • update public to private: failed preflight.: FAIL (Chrome: FAIL, Safari: FAIL)
  • update public to private: success.: FAIL (Chrome: FAIL, Safari: FAIL)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7998603ea320
[wpt PR 36100] - [Private Network Access] Fix test cases in service-worker-update.https.window.js, a=testonly

Comment 4

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/7998603ea320