1793022 - [wpt-sync] Sync PR 36095 - Miss the cache when truncated by the fragmentation line.

Status: RESOLVED FIXED

(Core :: Layout, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 36095 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/36095
Details from upstream follow.

Morten Stenshorne <[e-mail]> wrote:

Miss the cache when truncated by the fragmentation line.

If a fragment got truncated by the fragmentation line, and the
fragmentation line has moved (relatively to the fragment), we cannot
re-use it.

Fragments may get truncated if there's trailing margin or
border-spacing.

Also need to rebaseline fast/block/basic/align-attribute-ltr.html
which got incorrectly rebaselined in CL:3829558 (must have drowned in
all the other rebaseline noise there), and this is what allowed the
border-spacing part of the issue to enter our codebase "unnoticed".
The margin part is an old bug, though.

Bug: 1368054
Change-Id: I226907a3a2af8cbe44e7871c7ae8bd038bc0d2ee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3917855
Reviewed-by: Ian Kilpatrick \<[e-mail]>
Commit-Queue: Morten Stenshorne \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1051968}

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=2cf7f56180a33b024eba1b06e48bd4e51a40d7ed

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 3 tests

Status Summary

Firefox

PASS: 2
FAIL: 1

Chrome

FAIL: 3

Safari

PASS: 3

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /css/css-break/truncated-margin-at-fragmentainer-end-001.html [wpt.fyi]: FAIL (Chrome: FAIL, Safari: PASS)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/24b556a8d471
[wpt PR 36095] - Miss the cache when truncated by the fragmentation line., a=testonly
https://hg.mozilla.org/integration/autoland/rev/e7479f832a2e
[wpt PR 36095] - Update wpt metadata, a=testonly

Comment 4

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/24b556a8d471
https://hg.mozilla.org/mozilla-central/rev/e7479f832a2e