Note: There are a few cases of duplicates in user autocompletion which are being worked on.

Cannot trigger form controls or links using page accesskey

RESOLVED FIXED in Camino0.9

Status

Camino Graveyard
Accessibility
P2
normal
RESOLVED FIXED
15 years ago
12 years ago

People

(Reporter: Avi Drissman, Assigned: Simon Fraser)

Tracking

({access, html4})

unspecified
Camino0.9
PowerPC
Mac OS X
access, html4

Details

(URL)

Attachments

(1 attachment, 3 obsolete attachments)

(Reporter)

Description

15 years ago
User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X; en-US; rv:1.0.1) Gecko/20021029 Chimera/0.5+
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X; en-US; rv:1.0.1) Gecko/20021029 Chimera/0.5+

Form controls marked with accesskey parameters don't respond to the access keys.

Reproducible: Always

Steps to Reproduce:
1. Go to the Bugzilla query page.
2. Try to use an accesskey.


Actual Results:  
Try command. Control. Option. Shift-all of the above. None trigger it.
(Reporter)

Updated

15 years ago
Summary: accesskey → Cannot trigger form controls using accesskey

Comment 1

15 years ago
Yeah, I don't think accesskeys were ever fixed on Mac. There's probably a bug
about it somewhere...
(Reporter)

Comment 2

15 years ago
You mean bug 122479. Hmm. Dup? Should this be covered by that bug?
confirming. not sure if this is a dup of bug 122479...
Status: UNCONFIRMED → NEW
Ever confirmed: true
this appears to be a problem within chimera, as it's not a problem in mozilla
--trunk or 1.0.2 branch.

here's another test case, where Ctrl-1 (and ctrl-2, Ctrl-3, etc) will focus the
textfields in the form (in mozilla, but not chimera):

http://www.cs.hmc.edu/~jruderma/s/

i think bug 122479 is a similar but different bug, which prolly affects both
chimera and mozilla on mac.
Summary: Cannot trigger form controls using accesskey → Cannot trigger form controls using page accesskey

Comment 5

14 years ago
The problem affects also links: try
http://www.francocarcillo.it/dive/accessibility_statement.html
The acceskeys don't work.
I'm using Build ID: 2003042705

The same keys work fine on Mozilla 1.3 (Gecko/20030312)

ACCESSIBILITY IS A MUST!
Confirming with 2003082402

Updated

14 years ago
Keywords: access, html4

Comment 7

13 years ago
Camino is a fine, /fine/, browser ... but this accesskey problem is the only
reason I'll venture back to Safari now and then.  (There's one website I
frequent for which the accesskeys are muscle memory now.)
Target Milestone: --- → Camino0.9

Comment 8

13 years ago
Could either Jasper, Mike, or Stuart please explain what is going on with this
bug? Why is there a nib that removes a delete icon that was never added? Do we
just need to land a little cleanup patch?

It seems to me we should have a delete button and the edit menu should work.
Either way this bug should be easy to knock off the 0.9 list.

Comment 9

13 years ago
That last comment of mine is posted in the wrong bug... ignore it.

Updated

13 years ago
Assignee: bryner → sfraser_bugs

Comment 10

13 years ago
Neat idea for Accesskey application. Forgive me if the wrong place.
http://www.mozdev.org/pipermail/camino/2004-March/001696.html
Ping.

This hasn't yet been marked as a 09 blocker, but I think it *needs* to be ready
by then. Has anyone taken a look at it recently?
Flags: camino0.9?
Summary: Cannot trigger form controls using page accesskey → Cannot trigger form controls or links using page accesskey
I'm pinging this again. No one's touched it and it's an 09 blocker. Can someone
look more into this? How hard is this to implement? If it's not something that
should be in 09 (or can be in 09 due to time constraint), let's move it to 1.0.
(Assignee)

Comment 13

12 years ago
Created attachment 187266 [details]
Fix cocoa event dispatching to correctly handle control-modified key events

This patch fixes access keys by making sure that we dispatch the correct
KEY_PRESS events when the control key is down.

The patch also contains some renaming of the various -convert: methods to
reduce reader confusion, and guts nsChildView::ModalEventFilter(), since that
is all bogus code.
Attachment #187266 - Flags: review?(joshmoz)
(Assignee)

Updated

12 years ago
Status: NEW → ASSIGNED
Priority: -- → P2

Comment 14

12 years ago
Oy Simon, it appears you only attached a testcase and no actual patch.
(Assignee)

Comment 15

12 years ago
Created attachment 187291 [details] [diff] [review]
The patch this time.
Attachment #187266 - Attachment is obsolete: true
Attachment #187291 - Flags: review?(joshmoz)

Updated

12 years ago
Attachment #187266 - Attachment is patch: false
Attachment #187266 - Attachment mime type: text/plain → text/html
(Assignee)

Updated

12 years ago
Attachment #187266 - Flags: review?(joshmoz)

Comment 16

12 years ago
Aside from the fact that the patch doesn't apply, the following concerns me:

/Users/josh/src/camino_opt/mozilla/widget/src/cocoa/nsChildView.mm: In function 
   `void -[ChildView mouseUp:](ChildView*, objc_selector*, NSEvent*)':
/Users/josh/src/camino_opt/mozilla/widget/src/cocoa/nsChildView.mm:2569: warning: `
   ChildView' may not respond to `-convert:message:toGeckoEvent:'
/Users/josh/src/camino_opt/mozilla/widget/src/cocoa/nsChildView.mm:2569:
warning: cannot
   find method `-convert:message:toGeckoEvent:'; return type `id' assumed

Updated

12 years ago
Attachment #187291 - Flags: review?(joshmoz) → review-

Comment 17

12 years ago
Created attachment 187429 [details] [diff] [review]
updated to trunk, warnings not fixed yet
Attachment #187291 - Attachment is obsolete: true
(Assignee)

Comment 18

12 years ago
Created attachment 187440 [details] [diff] [review]
Updated patch to trunk
Attachment #187429 - Attachment is obsolete: true
Attachment #187440 - Flags: review?(joshmoz)

Updated

12 years ago
Attachment #187440 - Flags: review?(joshmoz) → review+
(Assignee)

Comment 19

12 years ago
Checked in. Thanks!
Status: ASSIGNED → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED
Er, this was landed, so removing the obsolete ? flag.  Sorry for the noise.
Flags: camino0.9?
You need to log in before you can comment on or make changes to this bug.