Closed
Bug 179308
Opened 22 years ago
Closed 19 years ago
Cannot trigger form controls or links using page accesskey
Categories
(Camino Graveyard :: Accessibility, defect, P2)
Tracking
(Not tracked)
RESOLVED
FIXED
Camino0.9
People
(Reporter: avi, Assigned: sfraser_bugs)
References
()
Details
(Keywords: access, html4)
Attachments
(1 file, 3 obsolete files)
14.22 KB,
patch
|
jaas
:
review+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (Macintosh; U; PPC Mac OS X; en-US; rv:1.0.1) Gecko/20021029 Chimera/0.5+
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X; en-US; rv:1.0.1) Gecko/20021029 Chimera/0.5+
Form controls marked with accesskey parameters don't respond to the access keys.
Reproducible: Always
Steps to Reproduce:
1. Go to the Bugzilla query page.
2. Try to use an accesskey.
Actual Results:
Try command. Control. Option. Shift-all of the above. None trigger it.
Reporter | ||
Updated•22 years ago
|
Summary: accesskey → Cannot trigger form controls using accesskey
Yeah, I don't think accesskeys were ever fixed on Mac. There's probably a bug
about it somewhere...
Reporter | ||
Comment 2•22 years ago
|
||
You mean bug 122479. Hmm. Dup? Should this be covered by that bug?
Comment 3•22 years ago
|
||
confirming. not sure if this is a dup of bug 122479...
Status: UNCONFIRMED → NEW
Ever confirmed: true
Comment 4•22 years ago
|
||
this appears to be a problem within chimera, as it's not a problem in mozilla
--trunk or 1.0.2 branch.
here's another test case, where Ctrl-1 (and ctrl-2, Ctrl-3, etc) will focus the
textfields in the form (in mozilla, but not chimera):
http://www.cs.hmc.edu/~jruderma/s/
i think bug 122479 is a similar but different bug, which prolly affects both
chimera and mozilla on mac.
Updated•22 years ago
|
Summary: Cannot trigger form controls using accesskey → Cannot trigger form controls using page accesskey
Comment 5•22 years ago
|
||
The problem affects also links: try
http://www.francocarcillo.it/dive/accessibility_statement.html
The acceskeys don't work.
I'm using Build ID: 2003042705
The same keys work fine on Mozilla 1.3 (Gecko/20030312)
ACCESSIBILITY IS A MUST!
Comment 6•21 years ago
|
||
Confirming with 2003082402
Updated•21 years ago
|
Comment 7•20 years ago
|
||
Camino is a fine, /fine/, browser ... but this accesskey problem is the only
reason I'll venture back to Safari now and then. (There's one website I
frequent for which the accesskeys are muscle memory now.)
Updated•20 years ago
|
Target Milestone: --- → Camino0.9
Could either Jasper, Mike, or Stuart please explain what is going on with this
bug? Why is there a nib that removes a delete icon that was never added? Do we
just need to land a little cleanup patch?
It seems to me we should have a delete button and the edit menu should work.
Either way this bug should be easy to knock off the 0.9 list.
That last comment of mine is posted in the wrong bug... ignore it.
Comment 10•20 years ago
|
||
Neat idea for Accesskey application. Forgive me if the wrong place.
http://www.mozdev.org/pipermail/camino/2004-March/001696.html
Comment 11•19 years ago
|
||
Ping.
This hasn't yet been marked as a 09 blocker, but I think it *needs* to be ready
by then. Has anyone taken a look at it recently?
Flags: camino0.9?
Summary: Cannot trigger form controls using page accesskey → Cannot trigger form controls or links using page accesskey
Comment 12•19 years ago
|
||
I'm pinging this again. No one's touched it and it's an 09 blocker. Can someone
look more into this? How hard is this to implement? If it's not something that
should be in 09 (or can be in 09 due to time constraint), let's move it to 1.0.
Assignee | ||
Comment 13•19 years ago
|
||
This patch fixes access keys by making sure that we dispatch the correct
KEY_PRESS events when the control key is down.
The patch also contains some renaming of the various -convert: methods to
reduce reader confusion, and guts nsChildView::ModalEventFilter(), since that
is all bogus code.
Attachment #187266 -
Flags: review?(joshmoz)
Assignee | ||
Updated•19 years ago
|
Status: NEW → ASSIGNED
Priority: -- → P2
Comment 14•19 years ago
|
||
Oy Simon, it appears you only attached a testcase and no actual patch.
Assignee | ||
Comment 15•19 years ago
|
||
Attachment #187266 -
Attachment is obsolete: true
Attachment #187291 -
Flags: review?(joshmoz)
Attachment #187266 -
Attachment is patch: false
Attachment #187266 -
Attachment mime type: text/plain → text/html
Assignee | ||
Updated•19 years ago
|
Attachment #187266 -
Flags: review?(joshmoz)
Comment 16•19 years ago
|
||
Aside from the fact that the patch doesn't apply, the following concerns me:
/Users/josh/src/camino_opt/mozilla/widget/src/cocoa/nsChildView.mm: In function
`void -[ChildView mouseUp:](ChildView*, objc_selector*, NSEvent*)':
/Users/josh/src/camino_opt/mozilla/widget/src/cocoa/nsChildView.mm:2569: warning: `
ChildView' may not respond to `-convert:message:toGeckoEvent:'
/Users/josh/src/camino_opt/mozilla/widget/src/cocoa/nsChildView.mm:2569:
warning: cannot
find method `-convert:message:toGeckoEvent:'; return type `id' assumed
Attachment #187291 -
Flags: review?(joshmoz) → review-
Comment 17•19 years ago
|
||
Attachment #187291 -
Attachment is obsolete: true
Assignee | ||
Comment 18•19 years ago
|
||
Attachment #187429 -
Attachment is obsolete: true
Attachment #187440 -
Flags: review?(joshmoz)
Attachment #187440 -
Flags: review?(joshmoz) → review+
Assignee | ||
Comment 19•19 years ago
|
||
Checked in. Thanks!
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Er, this was landed, so removing the obsolete ? flag. Sorry for the noise.
Flags: camino0.9?
You need to log in
before you can comment on or make changes to this bug.
Description
•