Closed Bug 1793122 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 36177 - [scoped-registry] Allow attaching a registry when creating a shadow root

Categories

(Core :: DOM: Core & HTML, task, P4)

task

Tracking

()

RESOLVED FIXED
108 Branch
Tracking Status
firefox108 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 36177 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/36177
Details from upstream follow.

Xiaocheng Hu <xiaochengh@chromium.org> wrote:

[scoped-registry] Allow attaching a registry when creating a shadow root

This patch adds a registry parameter to ShadowRootInit so that we
can attach a registry when creating a shadow root. It also adds a
ShadowRoot.registry readonly attribute to return the attached registry
of a shadow root.

Bug: 1304439
Change-Id: I0514cd9d25d6fab2696b468ab0d066677bd66e6a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3915480
Reviewed-by: David Baron \<dbaron@chromium.org>
Commit-Queue: Xiaocheng Hu \<xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1053679}

Component: web-platform-tests → DOM: Core & HTML
Product: Testing → Core
Whiteboard: [wptsync downstream] → [wptsync downstream error]

CI Results

Ran 10 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 5 subtests

Status Summary

Firefox

OK : 1
FAIL: 5

Chrome

OK : 1
FAIL: 5

Safari

OK : 1
FAIL: 5

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

  • /custom-elements/scoped-registry/ShadowRoot-init-registry.tentative.html [wpt.fyi]
    • ShadowRoot.registry is null if not explicitly specified: FAIL (Chrome: FAIL, Safari: FAIL)
    • Attach the global registry to a shadow root: FAIL (Chrome: FAIL, Safari: FAIL)
    • Attach a non-global registry to a shadow root: FAIL (Chrome: FAIL, Safari: FAIL)
    • Attach the same registry to multiple shadow roots: FAIL (Chrome: FAIL, Safari: FAIL)
    • Attaching registry to shadow root can only be done during initialization: FAIL (Chrome: FAIL, Safari: FAIL)
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/5f2f8254ca38 [wpt PR 36177] - [scoped-registry] Allow attaching a registry when creating a shadow root, a=testonly https://hg.mozilla.org/integration/autoland/rev/1f7848e12530 [wpt PR 36177] - Update wpt metadata, a=testonly
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 108 Branch
You need to log in before you can comment on or make changes to this bug.