1793218 - webrender blacklist prefs saved in prefs.js

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect, P3)

Description

[morgan.hager1]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:105.0) Gecko/20100101 Firefox/105.0

Steps to reproduce:

1. Start Firefox on Linux with deprecated Intel DDX driver, causing hardware WebRender to be disabled
2. Quit Firefox and Xorg
3. Change Xorg config to use modesetting driver
4. Start Firefox and Xorg

Actual results:

WebRender is disabled until the about:config option gfx.blacklist.webrender is cleared manually

Expected results:

WebRender should have been re-enabled when Firefox was launched again, instead of requiring clearing a value manually

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Core::Graphics: WebRender' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[Jeff Muizelaar [:jrmuizel]]

Andrew, any thoughts on what's going on here?

Comment 3

[Andrew Osmond [:aosmond] (he/him)]

We don't appear to handle ALLOW_ALWAYS, ALLOW_QUALIFIED, DENIED, FEATURE_STATUS_UNKNOWN, or FEATURE_BLOCKED_PLATFORM_TEST:
https://searchfox.org/mozilla-central/rev/88f285c5163f73abd209d4f73cfa476660351982/widget/GfxInfoBase.cpp#1429

Comment 4

[Andrew Osmond [:aosmond] (he/him)]

Oh wait, I see there is a default switch just above the line I linked. That should have removed it although we should make this code clearer and handle the various status codes properly...

Comment 5

[Andrew Osmond [:aosmond] (he/him)]

Attachment: Bug 1793218 - Refactor gfx blocklist pref management to avoid missing features/status codes.

We have added a number of new status codes, for the allowlist and new
errors that were not previously handled by the code managing the gfx
blocklist prefs. We also now iterate over the range of features instead
of manually listing the features, as some were missed during previous
additions.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6d5007c0d55a
Refactor gfx blocklist pref management to avoid missing features/status codes. r=gfx-reviewers,lsalzman

Comment 7

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/6d5007c0d55a