1793245 - [wpt-sync] Sync PR 36208 - Revert "[scroll-animations] Support view-timeline-inset:auto"

Status: RESOLVED FIXED

(Testing :: web-platform-tests, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 36208 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/36208
Details from upstream follow.

Tim <[e-mail]> wrote:

Revert "[scroll-animations] Support view-timeline-inset:auto"

This reverts commit 43da846cd22a38845011b6c4003f9617217a90b7.

Reason for revert: Seeing a consistent failure on Mac bots for the modified test after this merged in. For first failure see: https://ci.chromium.org/ui/p/chromium/builders/ci/Mac12%20Tests/2430/overview

Original change's description:

[scroll-animations] Support view-timeline-inset:auto

When the author specifies view-timeline-inset:auto, it is supposed to
use the value from the corresponding scroll-padding property. This CL
implements that behavior.

Since some length utils expect LayoutUnit rather than double, it made
sense to keep values as LayoutUnits where possible to avoid converting
too much back and forth.

Also, it turns out that the default Length() constructor is effectively
"auto", so I had to change the default insets to Length::Fixed(), which
is "0".

Bug: 1317765
Change-Id: I45a07a228df90210db2d4f649071a4b1a482676b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3898672
Reviewed-by: Kevin Ellis \<[e-mail]>
Commit-Queue: Anders Hartvoll Ruud \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1053733}

Bug: 1317765
Change-Id: I733491e2c92a9a9ba020619814254d3c47fa7852
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3930735
Owners-Override: Tim Judkins \<[e-mail]>
Commit-Queue: Tim \<[e-mail]>
Bot-Commit: Rubber Stamper \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1053846}

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=7fcc379db7cde5523c2cb403f08a9c9898ae1602

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 10 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 8 subtests

Status Summary

Firefox

OK : 1
FAIL: 8

Chrome

OK : 1
FAIL: 8

Safari

OK : 1
FAIL: 8

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /scroll-animations/css/view-timeline-inset-animation.html [wpt.fyi]
  • view-timeline-inset with one value: FAIL (Chrome: FAIL, Safari: FAIL)
  • view-timeline-inset with two values: FAIL (Chrome: FAIL, Safari: FAIL)
  • view-timeline-inset with em values: FAIL (Chrome: FAIL, Safari: FAIL)
  • view-timeline-inset with percentage values: FAIL (Chrome: FAIL, Safari: FAIL)
  • view-timeline-inset with negative values: FAIL (Chrome: FAIL, Safari: FAIL)
  • view-timeline-inset with horizontal scroller: FAIL (Chrome: FAIL, Safari: FAIL)
  • view-timeline-inset with block scroller: FAIL (Chrome: FAIL, Safari: FAIL)
  • view-timeline-inset with inline scroller: FAIL (Chrome: FAIL, Safari: FAIL)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/616ea7b48fd5
[wpt PR 36208] - Revert "[scroll-animations] Support view-timeline-inset:auto", a=testonly

Comment 4

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/616ea7b48fd5