1793289 - Error: .size expression for ff_fft_calc_neon does not evaluate to a constant

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Ray Vine]

Building FF106.0b6, changeset b382879a5ba6, for armv7 fails with this error:

 media/ffvpx/libavcodec/arm
 media/ffvpx/libavcodec/arm/fft_neon.o
 media/ffvpx/libavcodec/arm/fft_vfp.o
 /tmp/ccSqKoQI.s: Assembler messages:
 /tmp/ccSqKoQI.s: Error: .size expression for ff_fft_calc_neon does not evaluate to a constant
 /tmp/ccSqKoQI.s: Error: .size expression for ff_fft_permute_neon does not evaluate to a constant
 gmake[4]: *** [/mozbuild/mozilla/config/rules.mk:664: fft_neon.o] Error 1
 gmake[3]: *** [/mozbuild/mozilla/config/recurse.mk:72: media/ffvpx/libavcodec/arm/target-objects] Error 2
 gmake[3]: *** Waiting for unfinished jobs....
 gmake[2]: *** [/mozbuild/mozilla/config/recurse.mk:34: compile] Error 2
 gmake[1]: *** [/mozbuild/mozilla/config/rules.mk:361: default] Error 2
 gmake: *** [client.mk:63: build] Error 2

The problem is introduced by the fix for bug #1765480.
Reversing the patch for c174bd2624e2 [configs], and the diffs in 2b8ef32d5cbe relevant to media/ffvpx/libavcodec/arm only [arm/flacdsp_init_arm.c and arm/cpu.c], fft_neon.o and fft_vfp.o will build.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:padenot, since you are the author of the regressor, bug 1765480, could you take a look? Also, could you set the severity field?

For more information, please visit auto_nag documentation.

Comment 2

[Ray Vine]

Without a # include "config_unix_arm.h" option in config.h, it's the #define EXTERN_ASM _ in config_generic.h that causes the error.

This fixes building with gcc

--- media/ffvpx/config_override.h
+++ media/ffvpx/config_override.h
@@ -30,3 +30,10 @@
 #endif
 
+// bug 1793289
+// override '#define EXTERN_ASM _' in config_generic.h
+#if defined(__GNUC__) && defined(__arm__)
+#undef EXTERN_ASM
+#define EXTERN_ASM
+#endif
+
 #endif

Comment 3

[Paul Adenot (:padenot)]

Attachment: Bug 1793289 - Override EXTERN_ASM when building ffvpx in generic / no asm configuration. r?alwu

Thanks to Ray Vine <[e-mail]> for the bug report and a suggested fix.

Comment 4

[Paul Adenot (:padenot)]

Thanks Ray, I'm attaching a patch with your suggestion, this should land shortly.

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1765480

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/81715fef2264
Override EXTERN_ASM when building ffvpx in generic / no asm configuration. r=alwu

Comment 7

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/81715fef2264