Closed Bug 1793300 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 36209 - Remove main element from SoftNav heuristics

Categories

(Testing :: web-platform-tests, task, P4)

Product:
Testing
Component:
web-platform-tests
Type:
task

Tracking

(firefox108 fixed)

Status:
RESOLVED FIXED
Milestone:
108 Branch
Tracking Flags:
Tracking Status
firefox108 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 36209 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/36209
Details from upstream follow.

Yoav Weiss <yoavweiss@chromium.org> wrote:

Remove main element from SoftNav heuristics

Given real-world SPAs don't necessarily have a main element, this CL
removes the main element requirement from the Soft Navigation
heuristics.

Change-Id: I2577466a1531f322db4c5b757157e6edc675b8dc
Bug: 1370306

Reviewed-on: https://chromium-review.googlesource.com/3930827
WPT-Export-Revision: f75fad13413ef279ebe2898f91f12503851f3fa7

CI Results

Ran 10 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 1 subtests

Status Summary

Firefox

OK : 1
FAIL : 1
TIMEOUT: 2

Chrome

TIMEOUT: 2

Safari

TIMEOUT: 2

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

  • /soft-navigation-heuristics/soft-navigation-detection-non-main.tentative.html [wpt.fyi]: OK [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-isolated-process-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-32-2004-qr-debug, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt], TIMEOUT [GitHub] (Chrome: TIMEOUT, Safari: TIMEOUT)
    • Test that a soft navigation is detected on a non-main element: FAIL [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-isolated-process-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-32-2004-qr-debug, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt], TIMEOUT [GitHub] (Chrome: TIMEOUT, Safari: TIMEOUT)
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d5d9cbe1aab8 [wpt PR 36209] - Remove main element from SoftNav heuristics, a=testonly https://hg.mozilla.org/integration/autoland/rev/cd6bd898bba4 [wpt PR 36209] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/d5d9cbe1aab8
https://hg.mozilla.org/mozilla-central/rev/cd6bd898bba4

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox108: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 108 Branch
You need to log in before you can comment on or make changes to this bug.