1793414 - MozSearchbar calls into BrowserSearch where it doesn't need to

Status: RESOLVED FIXED

(Firefox :: Search, task, P3)

Description

[Mark Banner (:standard8)]

Currently there are various places where MozSearchbar calls to BrowserSearch to either get itself, or to call a function which would be simpler to host in MozSearchBar to itself.

Comment 1

[Mark Banner (:standard8)]

Attachment: Bug 1793414 - Move paste and search handling for the search bar into the search bar code itself. r?jteow

Comment 2

[Mark Banner (:standard8)]

Attachment: Bug 1793414 - Remove MozSearchbar reliance on BrowserSearch where possible. r?jteow

Also moves modules to be loaded lazily to avoid unnecessarily loading them on startup.

Depends on D158499

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1f011637d116
Move paste and search handling for the search bar into the search bar code itself. r=jteow
https://hg.mozilla.org/integration/autoland/rev/f27b2a93224e
Remove MozSearchbar reliance on BrowserSearch where possible. r=jteow

Comment 4

[Sandor Molnar[:smolnar]]

Backed out for causing browser-chrome failures in browser/components/search/test/browser/browser_searchbar_context.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/83c0895d0f34788ad8271141e06b00ebdb0b9188

Push with failures

Failure log

INFO - TEST-PASS | browser/components/search/test/browser/browser_searchbar_context.js | Clipboard has the given value: 'test' - 
[task 2022-10-06T08:40:40.695Z] 08:40:40     INFO - Buffered messages finished
[task 2022-10-06T08:40:40.697Z] 08:40:40     INFO - TEST-UNEXPECTED-FAIL | browser/components/search/test/browser/browser_searchbar_context.js | Should have loaded the expected search page. - "about:newtab" == "https://example.com/?q=test" - JS frame :: chrome://mochitests/content/browser/browser/components/search/test/browser/browser_searchbar_context.js :: test_paste_and_go :: line 241
[task 2022-10-06T08:40:40.697Z] 08:40:40     INFO - Stack trace:

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bfa39e3eef0a
Move paste and search handling for the search bar into the search bar code itself. r=jteow
https://hg.mozilla.org/integration/autoland/rev/935f4758b5e6
Remove MozSearchbar reliance on BrowserSearch where possible. r=jteow

Comment 6

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/bfa39e3eef0a
https://hg.mozilla.org/mozilla-central/rev/935f4758b5e6