1793416 - [wpt-sync] Sync PR 36223 - Reset LCP sizes on soft navigations

Status: RESOLVED FIXED

(Testing :: web-platform-tests, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 36223 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/36223
Details from upstream follow.

Yoav Weiss <[e-mail]> wrote:

Reset LCP sizes on soft navigations

The current soft navigation LCP implementation restarts LCP tracking,
but does not reset older LCP values. As a result, only the largest
paints (since the hard navigation) are counted as soft navigation LCP.
That's not what we want. This CL fixes that.

Bug: 1369516
Change-Id: Ib42701699181abebcb4a345ad4cf5235f2d7d777
Reviewed-on: https://chromium-review.googlesource.com/3930137
WPT-Export-Revision: eaabfedbcdb07df6a3048f324c421609c1c5f9df

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

PR 36223 applied with additional changes from upstream: f6deb87e77e88240443d350310202bbb75ea97e9, 868f8fed98bd612b1bf1a41e311798787e613e57, cdfbcefa25614db31f4986eca434616bc7216533

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=e900219fb5bd0d00d6ee0a742260868320c87e27

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=266e9d3ac100e11b656c93a3d07248a79f9fd4d9

Comment 4

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 10 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 10 tests and 1 subtests

Status Summary

Firefox

TIMEOUT: 18[Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-isolated-process-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-32-2004-qr-debug, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt] 20[GitHub]

Chrome

OK : 9
PASS : 1
FAIL : 8
TIMEOUT: 2

Safari

TIMEOUT: 20

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /soft-navigation-heuristics/dropped-entries.tentative.html [wpt.fyi]: TIMEOUT (Chrome: OK, Safari: TIMEOUT)
  • Test that a soft navigation is detected when the click is done on a custom element.: TIMEOUT (Chrome: PASS, Safari: TIMEOUT)
• /soft-navigation-heuristics/image-lcp-followed-by-image-softnav-lcp.tentative.html [wpt.fyi]: TIMEOUT (Chrome: OK, Safari: TIMEOUT)
  • Test that an image LCP followup by a smaller soft navigation image LCP properly queues an LCP entry: TIMEOUT (Chrome: FAIL, Safari: TIMEOUT)
• /soft-navigation-heuristics/image-lcp-followed-by-text-softnav-lcp.tentative.html [wpt.fyi]: TIMEOUT (Chrome: OK, Safari: TIMEOUT)
  • Test that an image LCP followup by a smaller soft navigation text LCP properly queues an LCP entry: TIMEOUT (Chrome: FAIL, Safari: TIMEOUT)
• /soft-navigation-heuristics/soft-navigation-detection-main-descendent.tentative.html [wpt.fyi]: TIMEOUT (Chrome: OK, Safari: TIMEOUT)
  • Test that a soft navigation is detected even when DOM change is done on a main descendent: TIMEOUT (Chrome: FAIL, Safari: TIMEOUT)
• /soft-navigation-heuristics/soft-navigation-detection-web-component-lifecycle.tentative.html [wpt.fyi]: TIMEOUT (Chrome: OK, Safari: TIMEOUT)
  • Test that a soft navigation is detected when the click is done on a custom element.: TIMEOUT (Chrome: FAIL, Safari: TIMEOUT)
• /soft-navigation-heuristics/soft-navigation-detection.tentative.html [wpt.fyi]: TIMEOUT (Chrome: OK, Safari: TIMEOUT)
  • Test that a soft navigation is detected: TIMEOUT (Chrome: FAIL, Safari: TIMEOUT)
• /soft-navigation-heuristics/soft-navigation-no-url.tentative.html [wpt.fyi]: TIMEOUT (Chrome: OK, Safari: TIMEOUT)
  • Test that a soft navigation is detected: TIMEOUT (Chrome: FAIL, Safari: TIMEOUT)
• /soft-navigation-heuristics/text-lcp-followed-by-image-softnav-lcp.tentative.html [wpt.fyi]: TIMEOUT (Chrome: OK, Safari: TIMEOUT)
  • Test that a text LCP followup by a smaller soft navigation image LCP properly queues an LCP entry: TIMEOUT (Chrome: FAIL, Safari: TIMEOUT)
• /soft-navigation-heuristics/text-lcp-followed-by-text-softnav-lcp.tentative.html [wpt.fyi]: TIMEOUT (Chrome: OK, Safari: TIMEOUT)
  • Test that a text LCP followup by a smaller soft navigation text LCP properly queues an LCP entry: TIMEOUT (Chrome: FAIL, Safari: TIMEOUT)
• /soft-navigation-heuristics/soft-navigation-detection-non-main.tentative.html [wpt.fyi]: TIMEOUT (Chrome: TIMEOUT, Safari: TIMEOUT)
  • Test that a soft navigation is detected on a non-main element: TIMEOUT (Chrome: TIMEOUT, Safari: TIMEOUT)

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/311929f9e300
[wpt PR 36223] - Reset LCP sizes on soft navigations, a=testonly
https://hg.mozilla.org/integration/autoland/rev/41e2adc638df
[wpt PR 36223] - Update wpt metadata, a=testonly

Comment 6

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/311929f9e300
https://hg.mozilla.org/mozilla-central/rev/41e2adc638df