1793471 - [wpt-sync] Sync PR 36231 - Make load.cache_bust safe in multi-promise_test setting.

Status: RESOLVED FIXED

(Core :: DOM: Performance, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 36231 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/36231
Details from upstream follow.

William Liu <[e-mail]> wrote:

Make load.cache_bust safe in multi-promise_test setting.

This CL addresses the flakiness in crrev.com/c/3913675.
load.cache_bust1 isn't thread-friendly, where it is possible to get
two identical &unique=\<xxx> query params in two separated promise_test
in one js test file.

With two identical &unique=\<xxx>, initialURL in the "same origin" test and cacheAndValidatedURL in the "cross origin, TAO fails" test are also identical. It is unclear why promise_test is not happy about
two identical URL, and complaining about the ACAO header.

Tested with
third_party/blink/tools/run_web_tests.py -t Default external/wpt/resource-timing/delivery-type.tentative.any.js --repeat-each=20
on a linux build.

Bug:1370353, 1358591
Change-Id: I54b0c132ae0eeee96dbc6947bddedfa34b48e2c1

Reviewed-on: https://chromium-review.googlesource.com/3932083
WPT-Export-Revision: a19d2d4a66fd2d1552ef01620bb52341667f6470

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=b361e6807a0561e150d005c96fa8207170c06d47

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Attachment: Notable wpt changes

# CI Results

Ran 10 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 43 tests and 3 subtests

## Status Summary

### Firefox
`OK`     : 33[Gecko-android-em-7.0-x86_64-qr-debug-isolated-process-geckoview] 34[Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-32-2004-qr-debug, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt] 36[Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview] 38[GitHub]
`PASS`   : 131[GitHub] 132[Gecko-android-em-7.0-x86_64-qr-debug-isolated-process-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-32-2004-qr-debug, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt] 133[Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview]
`FAIL`   : 75[Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-32-2004-qr-debug, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt] 88[GitHub] 163[Gecko-android-em-7.0-x86_64-qr-debug-isolated-process-geckoview] 165[Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview]
`TIMEOUT`: 1[Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview] 4[Gecko-android-em-7.0-x86_64-qr-debug-isolated-process-geckoview] 5[Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-32-2004-qr-debug, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt] 7[GitHub]
`ERROR`  : 2
`NOTRUN` : 7[Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-isolated-process-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview] 96[Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-32-2004-qr-debug, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt, GitHub]

### Chrome
`OK`     : 42
`PASS`   : 311
`FAIL`   : 8
`ERROR`  : 1

### Safari
`OK`     : 33
`PASS`   : 36
`FAIL`   : 38
`TIMEOUT`: 17
`ERROR`  : 2
`NOTRUN` : 235

## Links
[Gecko CI (Treeherder)](https://treeherder.mozilla.org/#/jobs?repo=try&revision=b361e6807a0561e150d005c96fa8207170c06d47)
[GitHub PR Head](https://wpt.fyi/results/?sha=5d825246f083648d42299df1c4da073b30ea2882&label=pr_head)
[GitHub PR Base](https://wpt.fyi/results/?sha=5d825246f083648d42299df1c4da073b30ea2882&label=pr_base)

## Details

### Firefox-only Failures
* [/resource-timing/buffer-full-add-after-full-event.html](https://wpt.live/resource-timing/buffer-full-add-after-full-event.html) [[wpt.fyi](https://wpt.fyi/results/resource-timing/buffer-full-add-after-full-event.html)]: `SKIP` [`Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview`, `Gecko-android-em-7.0-x86_64-qr-debug-geckoview`, `Gecko-android-em-7.0-x86_64-qr-debug-isolated-process-geckoview`, `Gecko-android-em-7.0-x86_64-qr-opt-geckoview`, `Gecko-linux1804-64-qr-debug`, `Gecko-linux1804-64-qr-opt`, `Gecko-windows10-32-2004-qr-debug`, `Gecko-windows10-32-2004-qr-opt`, `Gecko-windows10-64-2004-qr-debug`, `Gecko-windows10-64-2004-qr-opt`], `TIMEOUT` [`GitHub`]
  * Test that entry was added to the buffer after a buffer full event: `TIMEOUT`
* [/resource-timing/buffer-full-add-then-clear.html](https://wpt.live/resource-timing/buffer-full-add-then-clear.html) [[wpt.fyi](https://wpt.fyi/results/resource-timing/buffer-full-add-then-clear.html)]
  * Test that if the buffer is cleared after entries were added to the secondary buffer, those entries make it into the primary one: `FAIL`
* [/resource-timing/buffer-full-then-increased.html](https://wpt.live/resource-timing/buffer-full-then-increased.html) [[wpt.fyi](https://wpt.fyi/results/resource-timing/buffer-full-then-increased.html)]
  * Test that overflowing the buffer and immediately increasing its limit does not trigger the resourcetimingbufferfull event: `FAIL`
* [/resource-timing/buffer-full-when-populate-entries.html](https://wpt.live/resource-timing/buffer-full-when-populate-entries.html) [[wpt.fyi](https://wpt.fyi/results/resource-timing/buffer-full-when-populate-entries.html)]: `ERROR`
  * Test that a buffer full event does not bubble and that resourcetimingbufferfull is called only once per overflow: `FAIL`
* [/resource-timing/iframe-redirect-without-location.html](https://wpt.live/resource-timing/iframe-redirect-without-location.html) [[wpt.fyi](https://wpt.fyi/results/resource-timing/iframe-redirect-without-location.html)]: `OK` [`Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview`, `Gecko-android-em-7.0-x86_64-qr-debug-geckoview`, `Gecko-android-em-7.0-x86_64-qr-debug-isolated-process-geckoview`, `Gecko-android-em-7.0-x86_64-qr-opt-geckoview`], `TIMEOUT` [`Gecko-linux1804-64-qr-debug`, `Gecko-linux1804-64-qr-opt`, `Gecko-windows10-32-2004-qr-debug`, `Gecko-windows10-32-2004-qr-opt`, `Gecko-windows10-64-2004-qr-debug`, `Gecko-windows10-64-2004-qr-opt`, `GitHub`]

(See attachment for full changes)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/69a26fcb606e
[wpt PR 36231] - Fix `load.cache_bust`'s random integer precision issue., a=testonly
https://hg.mozilla.org/integration/autoland/rev/d18e7f3761ec
[wpt PR 36231] - Update wpt metadata, a=testonly

Comment 4

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/69a26fcb606e
https://hg.mozilla.org/mozilla-central/rev/d18e7f3761ec