Closed Bug 1793539 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 36244 - SVG: Fix handling of lang and xml:lang attributes

Categories

(Core :: SVG, task, P4)

Product:
Core
Component:
SVG
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
108 Branch
Tracking Flags:
Tracking Status
firefox108 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 36244 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/36244
Details from upstream follow.

Kent Tamura <tkent@chromium.org> wrote:

SVG: Fix handling of lang and xml:lang attributes

Specification: https://svgwg.org/svg2-draft/struct.html#LangSpaceAttrs

SVGElement should handle lang and xml:lang attributes in the same way
as HTMLElement.

This CL affects \<text> rendering and dynamic :lang() selector
matching.
Note that SVG elements has supported :lang() matching, but dynamic
update of lang/xml:lang didn't invalidate selector matching correctly.

  • element.{h,cc} and html_element.{h,cc}:
    Move MapLanguageAttributeToLocale() from HTMLElement to Element.

  • runtime_enabled_features.json5:
    Add a runtime flag just in case, and enable it.

Bug: 1370460
Change-Id: Ifdfd7d16d3c9560a6eacc371e2c198a5e0e3a383

Reviewed-on: https://chromium-review.googlesource.com/3932377
WPT-Export-Revision: 91f64fd9b9ec1bdf2f180029fff259744f2ea795

Component: web-platform-tests → SVG
Product: Testing → Core

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, and Chrome on GitHub CI

Total 4 tests

Status Summary

Firefox

PASS: 2[Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-32-2004-qr-debug, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt] 4[Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview]
FAIL: 2[Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-32-2004-qr-debug, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt] 4[GitHub]

Chrome

FAIL: 4

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

  • /svg/text/reftests/lang-attribute-dynamic.svg [wpt.fyi]: FAIL [Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-32-2004-qr-debug, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt, GitHub], PASS [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview] (Chrome: FAIL)
  • /svg/text/reftests/lang-attribute.svg [wpt.fyi]: FAIL [GitHub], PASS [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-32-2004-qr-debug, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt] (Chrome: FAIL)
  • /svg/text/reftests/xml-lang-attribute-dynamic.svg [wpt.fyi]: FAIL [Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-32-2004-qr-debug, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt, GitHub], PASS [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview] (Chrome: FAIL)
  • /svg/text/reftests/xml-lang-attribute.svg [wpt.fyi]: FAIL [GitHub], PASS [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-32-2004-qr-debug, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt] (Chrome: FAIL)
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/f4331fc98fd5 [wpt PR 36244] - SVG: Fix handling of lang and xml:lang attributes, a=testonly https://hg.mozilla.org/integration/autoland/rev/7550d674f5bc [wpt PR 36244] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/f4331fc98fd5
https://hg.mozilla.org/mozilla-central/rev/7550d674f5bc

Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox108: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 108 Branch
You need to log in before you can comment on or make changes to this bug.