1793572 - Migrate WebRTC strings from .properties to Fluent

Status: RESOLVED FIXED

(Core :: WebRTC: Audio/Video, task)

Description

[Eemeli Aro [:eemeli]]

Some of these strings currently use the legacy PluralForm API, which we'd like to drop.

Comment 1

[Eemeli Aro [:eemeli]]

Attachment: Bug 1793572 - Convert webrtcIndicator.properties to Fluent. r=mconley!

Comment 2

[Eemeli Aro [:eemeli]]

Attachment: Bug 1793572 - Convert getUserMedia.sharingMenu strings from browser.properties to Fluent. r=mconley!

The list of items is now formatted using ListFormat rather than manually, which requires a new message webrtc-sharing-menuitem. Based on a review of the existing solutions [1], it should be acceptable to use the same pattern for all of them, even though this may effect a small change for the zh-TW locale.

[1] https://transvision.flod.org/string/?entity=browser/chrome/browser/browser.properties:getUserMedia.sharingMenuCamera&repo=gecko_strings

Depends on D158760

Comment 3

[Eemeli Aro [:eemeli]]

Attachment: Bug 1793572 - Convert WebRTCParent.jsm from .properties to Fluent. r=mconley!

The code is slightly cleaned up to not construct identifiers by concatenating strings, and to avoid using the requestTypes array when determining the prompt contents.

A few messages are moved to and from browser.ftl to group them better, though all of the "WebRTC Pop-up notifications" messages could also be moved from there to webrtcIndicator.ftl, which is now also included by browser.xhtml.

The message webrtc-allow-share-audio-capture-unsafe-delegation is added, as it appears to have been missed previously -- it's referred to in code, but the message itself was not defined.

Depends on D158761

Comment 4

[Eemeli Aro [:eemeli]]

try auto: https://treeherder.mozilla.org/jobs?repo=try&revision=2ff8e835c11effbecf026c77fa4f12a5c5e4dca8

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7f7572b89897
Convert webrtcIndicator.properties to Fluent. r=mconley,flod
https://hg.mozilla.org/integration/autoland/rev/774cecf1d9d8
Convert getUserMedia.sharingMenu strings from browser.properties to Fluent. r=mconley,flod
https://hg.mozilla.org/integration/autoland/rev/bf745ae89c66
Convert WebRTCParent.jsm from .properties to Fluent. r=mconley,flod

Comment 6

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/7f7572b89897
https://hg.mozilla.org/mozilla-central/rev/774cecf1d9d8
https://hg.mozilla.org/mozilla-central/rev/bf745ae89c66