1793605 - On Headless and Linux new windows appear to not open at their intended size immediately.

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[matc]

Steps to reproduce:

Open a new window an log its sizes.

onclick = function () {
  let win = open(document.location.href, "", "width=200,height=200");
  console.log(win.innerWidth, win.innerHeight);
  win.onload = function () {
    console.log(win.innerWidth, win.innerHeight);
    win.close();
  };
};

This behavior started after Bug 1786513 (Make SimpleResizeReflow not flush by default.). The windows do indeed open at their intended size but the layout is not flushed early enough.

Actual results:

Log looks like:

1280 931
200 200

Expected results:

Log should look like:

200 200
200 200

Comment 1

[matc]

Attachment: Bug 1793605 - Flush layout in window.open calls with specified size. r=emilio

Without flushing the layout, new windows appear to initially open at the
size of their opener instead of their intended size.

We can flush the layout from OpenWindowInternal when we have access to
chrome. For remote tabs we can extend the condition for
nsFrameLoader::ForceLayoutIfNecessary to also apply when the pres shell
needs a layout flush.

Comment 2

[Emilio Cobos Álvarez [:emilio]]

Attachment: Test-case from comment 0

Comment 3

[matc]

I extended the test case a bit to include the view from the content in the new window. And it looks like by the time the content gets to run scripts the layout is reliably already flushed (without any of my changes), e.g. the window appears properly sized to the content in the new window.

Comment 4

[Emilio Cobos Álvarez [:emilio]]

Attachment: avoid-tokenizing-twice.patch

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3549afc9ae93
Flush layout in window.open calls with specified size. r=emilio

Comment 6

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/3549afc9ae93