1793629 - Implement origin controls attention indicator for the Unified extensions button

Status: RESOLVED FIXED

(WebExtensions :: General, enhancement)

Description

[Tomislav Jovanovic :zombie]

Breaking off as a followup from bug 1777343, since it will require a totally separate way of tracking tab switches and navigations from the one used for browserActions.

Comment 1

[Tomislav Jovanovic :zombie]

Attachment: Bug 1793629 - Implement attention indicator for the unified extensions button, r?willdurand

Comment 3

[William Durand [:willdurand]]

I marked the original Bug 1784239 as duplicate since you attached a patch to this one.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c5a9bca461ce
Implement attention indicator for the unified extensions button, r=willdurand

Comment 5

[Norisz Fay [:noriszfay]]

Backed out for causing multiple mochitest failures

Backout link

Push with failures

Failure log 1 // Failure log 2 // Failure log 3 // Failure log 4 // Failure log 5

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f8554e4080f2
Implement attention indicator for the unified extensions button, r=willdurand

Comment 7

[Cristian Tuns]

Backed out for causing mochitest failures on browser_preferences_usage.js

• Backout link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | browser/base/content/test/performance/browser_preferences_usage.js | extensions.getAddons.cache.enabled should be accessed at most 55 times. - 133 <= 55 - JS frame :: chrome://mochitests/content/browser/browser/base/content/test/performance/browser_preferences_usage.js :: checkPrefGetters :: line 63

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/27a859f55fdd
Implement attention indicator for the unified extensions button, r=willdurand

Comment 9

[Cosmin Sabou [:CosminS]]

Backed out for causing bc failures on browser_preferences_usage.js.

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&selectedTaskRun=Jeq5xUSfTwiWsBlEJA0KyA.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cusercancel&revision=27a859f55fdd489704a82225d46a9496341cfcc2

Failure log: https://treeherder.mozilla.org/logviewer?job_id=393587468&repo=autoland

Backout link: https://hg.mozilla.org/integration/autoland/rev/f8a3547d724152d91d16cfc554b28736c842652c

Comment 10

[Andrej (:aglavic)]

(In reply to Cristian Tuns from comment #7)

Backed out for causing mochitest failures on browser_preferences_usage.js

• Backout link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | browser/base/content/test/performance/browser_preferences_usage.js | extensions.getAddons.cache.enabled should be accessed at most 55 times. - 133 <= 55 - JS frame :: chrome://mochitests/content/browser/browser/base/content/test/performance/browser_preferences_usage.js :: checkPrefGetters :: line 63

== Change summary for alert #35695 (as of Wed, 19 Oct 2022 07:26:52 GMT) ==

Improvements:

Ratio	Test	Platform	Options	Absolute values (old vs new)
7%	tsvg_static	windows10-64-shippable-qr	e10s fission stylo webrender	52.45 -> 48.96
6%	tsvgr_opacity	windows10-64-shippable-qr	e10s fission stylo webrender-sw	70.25 -> 65.92
For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=35695

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/683d43b563fe
Implement attention indicator for the unified extensions button, r=willdurand

Comment 12

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/683d43b563fe