1793650 - [wpt-sync] Sync PR 36259 - Fix a crash in NearestOpenAncestralPopup for dialogs

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 36259 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/36259
Details from upstream follow.

Mason Freed <[e-mail]> wrote:

Fix a crash in NearestOpenAncestralPopup for dialogs

It was possible to have a \<dialog popup> that was visible (via
.showModal) and that was therefore incorrectly detected as a newly-
shown pop-up. This CL changes the logic to explicitly pass in whether
the pop-up is a new one.

Bug: 1307772
Change-Id: I4026b68fb92621ed23771214ba23db1f7c39d722
Reviewed-on: https://chromium-review.googlesource.com/3933891
WPT-Export-Revision: 2be70bd268284d7229f61fb80f8d25ef3d7a443f

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=24a59767daa3eb0e835a6df16378b81387a252f3

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, and Chrome on GitHub CI

Total 1 tests

Status Summary

Firefox

PASS: 1

Chrome

PASS: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a838e498baa9
[wpt PR 36259] - Fix a crash in NearestOpenAncestralPopup for dialogs, a=testonly

Comment 4

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/a838e498baa9