Closed Bug 1793657 Opened 2 years ago Closed 2 years ago

Create feature callout messages for pdf.js

Categories

(Firefox :: Messaging System, enhancement, P1)

Product:
Firefox
Component:
Messaging System
Type:
enhancement

Tracking

()

Status:
VERIFIED FIXED
Milestone:
108 Branch
Iteration:
108.1 - Oct 17 - Oct 28
Tracking Flags:
Tracking Status
firefox108 --- verified
firefox109 --- verified

People

(Reporter: jprickett, Assigned: jprickett)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Bug 1793657 - Created messages for Feature Callout tour in pdf.js r?mviar
48 bytes, text/x-phabricator-request
Details | Review
No description provided.
Iteration: --- → 107.2 - Oct 3 - Oct 14

Messages can live alongside existing feature callout messages, but we'll need some logic to only use the certain messages for a particular page

Assignee: nobody → jprickett
Status: NEW → ASSIGNED

I imagine we'll want to make this bug dependent on bug 1794651 and either include the custom positioning logic here or in a spin-off bug dependent on this one.

Blocks: 1794651
Iteration: 107.2 - Oct 3 - Oct 14 → 108.1 - Oct 17 - Oct 28
Blocks: 1797368
Blocks: 1793658
Attachment #9297293 - Attachment description: WIP: Bug 1793657 - Created messages for Feature Callout tour in pdf.js → Bug 1793657 - Created messages for Feature Callout tour in pdf.js r?mviar
No longer blocks: 1797368
Depends on: 1797368
Pushed by jprickett@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/78c6115b623f
Created messages for Feature Callout tour in pdf.js r=mviar

https://hg.mozilla.org/mozilla-central/rev/78c6115b623f

Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox108: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 108 Branch
No longer depends on: 1797368

We may need to rethink how we handle these messages. This will be an off-train experiment, but we're also handling tour progress using a pref. Also, the messages here only represent one of the two treatments. We'll also want to add the position overrides.

I'm marking this enhancement as verified based on the testing report sent for the "Callout: Pdf annotations for Fx109" bugwork.

Status: RESOLVED → VERIFIED
status-firefox108: fixed → verified
status-firefox109: --- → verified
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: