1793668 - test262-update.py script --local argument doesn't work in python 3

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P3)

Description

[Tim Chevalier]

Running this command:

python3 test262-update.py --local=$HOME/test262 --branch=change-array-by-copy

I got the error:

Traceback (most recent call last):
  File "/home/tjc/gecko-fork/js/src/tests/test262-update.py", line 900, in <module>
    args.func(args)
  File "/home/tjc/gecko-fork/js/src/tests/test262-update.py", line 837, in update_test262
    return fetch_local_changes(inDir, outDir, srcDir, strictTests)
  File "/home/tjc/gecko-fork/js/src/tests/test262-update.py", line 585, in fetch_local_changes
    ).split("\n")[0]
TypeError: a bytes-like object is required, not 'str'

The script worked when I replaced python3 with python2. If the intention is that this script requires python2, that should be documented.

$ python3 --version
Python 3.10.6
$ python2 --version
Python 2.7.18

Comment 1

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

It seems like it's the --local flag in particular that's causing trouble. This also breaks the integration test in js/src/tests/test/run.py; I'm disabling the test in bug 1891746 with a pointer here.

Comment 2

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Bug 1793668 - fix test262-update.py --local in python 3; r?#spidermonkey-reviewers

Comment 3

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Bug 1793668 - Update test for test262-import.py; r?#spidermonkey-reviewers

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/56d2d09c8d54
fix test262-update.py --local in python 3; r=spidermonkey-reviewers,dminor
https://hg.mozilla.org/integration/autoland/rev/c8793cd3262e
Update test for test262-import.py; r=dminor

Comment 5

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/56d2d09c8d54
https://hg.mozilla.org/mozilla-central/rev/c8793cd3262e