1793701 - [wpt-sync] Sync PR 36275 - Revert "[bfcache] Add notRestoredReasons field in PerformanceNavigationTiming"

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 36275 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/36275
Details from upstream follow.

Emily Shack <[e-mail]> wrote:

Revert "[bfcache] Add notRestoredReasons field in PerformanceNavigationTiming"

This reverts commit e1af9facf232a11871b0c668b90ec17c5a5d5e16.

Reason for revert: Likely cause for multiple builder failures. For example, see https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20ASan%20Tests%20(sandboxed)/93643/overview

Original change's description:

[bfcache] Add notRestoredReasons field in PerformanceNavigationTiming

This CL adds back/forward cache not restored reasons in Performance
NavigationTiming API.
It's proposed here:
https://github.com/w3c/navigation-timing/issues/171
Explainer: https://github.com/rubberyuzu/bfcache-not-retored-reason/blob/main/NotRestoredReason.md

This CL does two things:

• exposes not restored reasons to PerformanceNavigationTiming API
• adds WPT

The WPT have to run on all platforms because this API is intended to
collect bfcache metrics from the wild, regardless of the platforms.

LOW_COVERAGE_REASON=Adding coverage for new field. Just missing the tests for the existing fields

Bug: 1349228
Change-Id: I8dd96a60188bdff94a21c4e4e34cacf181a823db
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3835534
Reviewed-by: Daniel Cheng \<[e-mail]>
Reviewed-by: Kentaro Hara \<[e-mail]>
Reviewed-by: Weizhong Xia \<[e-mail]>
Commit-Queue: Yuzu Saijo \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1054800}

Bug: 1349228
Change-Id: Iab0fed375560bb0b09bf4e8ea18b80c5d88b1375
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3935464
Owners-Override: Emily Shack \<[e-mail]>
Reviewed-by: Kentaro Hara \<[e-mail]>
Commit-Queue: Kentaro Hara \<[e-mail]>
Auto-Submit: Emily Shack \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1055015}

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

PR 36275 applied with additional changes from upstream: 88c0d4ec3d12f5389297f08ced7785e2c402cf36

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=54cb16030872028b96875a18a2bb26bb9dd26b9b

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 15 tests and 1 subtests

Status Summary

Firefox

OK : 15
PASS: 15

Chrome

OK : 15
PASS: 15

Safari

OK : 15
PASS: 15

Links

GitHub PR Head
GitHub PR Base

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1217e1e14a2f
[wpt PR 36275] - Revert "[bfcache] Add notRestoredReasons field in PerformanceNavigationTiming", a=testonly

Comment 5

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/1217e1e14a2f