1793742 - Not able to Lock Credit Card Autofill Preferences

Status: VERIFIED FIXED

(Toolkit :: Preferences, defect, P3)

Description

[Wolfgang Andreas]

Steps to reproduce:

Firefox 102.3.0esr
Original question: https://github.com/mozilla/policy-templates/issues/887#issuecomment-1267120498

Currently we are disabling saving credit card autofill information via GPO (Preferences) but settings are not getting locked ("greyed out") for users.

"extensions.formautofill.creditCards.enabled": { "Value": false, "Status": "locked" },
"extensions.formautofill.creditCards.available": { "Value": false, "Status": "locked" }

Actual results:

Credit Card Autofill is correctly disabled but the setting is not locked, so users are still able to activate this setting by themselves.

Expected results:

Users are not able to change the credit card autofill settings.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Toolkit::Form Autofill' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[Wolfgang Andreas]

We noticed, that this also applies to the settings "dom.security_https_only_mode" and "dom.security.https_only_mode_ever_enabled" - could those also be locked? Thank you :-)

Comment 3

[Mike Kaply [:mkaply]]

Attachment: Bug 1793742 - Disable autofill prefs when locked by policy. r?tgiles

Comment 4

[Mike Kaply [:mkaply]]

We noticed, that this also applies to the settings "dom.security_https_only_mode" and "dom.security.https_only_mode_ever_enabled" - could those also be locked? Thank you :-)

Can you do me a favor and open a separate bug for that? I should be able to fix that fairly fast too.

Comment 5

[Wolfgang Andreas]

Hi Mike, no problem :-) We opened a new bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1793905 - Regards Wolfgang

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c6fb104ec9cb
Disable autofill prefs when locked by policy. r=tgiles,credential-management-reviewers,sgalich

Comment 7

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/c6fb104ec9cb

Comment 8

[Alin Ilea, Desktop Test Engineering]

Verified - Fixed in Beta 107.0b2 and the latest Nightly 108.0a1 (2022-10-20) using Windows 10. Both extensions.formautofill.creditCards.enabled and extensions.formautofill.creditCards.available pref are disabled and locked via policies.json.

Comment 9

[Mike Kaply [:mkaply]]

Attachment: ESR patch

Comment 10

[Mike Kaply [:mkaply]]

Comment on attachment 9301541 [details]
ESR patch

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: Parity with Firefox 107
• User impact if declined: Preferences locked via policy aren't disabled in preferences
• Fix Landed on Version: 107
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Autoamated test, policy only.

Comment 11

[Donal Meehan [:dmeehan]]

Comment on attachment 9301541 [details]
ESR patch

Approved for 102.5esr.

Comment 12

[Donal Meehan [:dmeehan]]

https://hg.mozilla.org/releases/mozilla-esr102/rev/d3eabae8f6b9

Comment 13

[Alin Ilea, Desktop Test Engineering]

Verified - Fixed in 102.5.0esr (build id: 20221107191025) using Windows 10. extensions.formautofill.creditCards.enabled and extensions.formautofill.creditCards.available prefs are disabled and locked via policies.json.