1793784 - Replace the minidump_writer_linux crate with the minidump-writer crate

Status: RESOLVED FIXED

(Toolkit :: Crash Reporting, task)

Description

[Gabriele Svelto [:gsvelto]]

The minidump_writer_linux crate was the first replacement we used for writing minidumps w/o using Breakpad code; it has since been replaced by the minidump-writer code which is based on it but supports Android, macOS and Windows.

Ideally we should switch to that crate but there's an issue that prevents us from doing it with upstream: the crate depends on windows-sys which we can't vendor at the moment. As a stop-gap solution I'll fork upstream and rewrite the crate to rely on the winapi crate instead - the changes are minimal and keeping up with upstream is not a problem at the moment as I'm involved in its development.

This will require vendoring a few more small crates and a large one: minidump-common. We won't be building this crate right away, it will only be built once we enable Windows support which is off for now. While it's unpleasant to vendor large crates we know they'll be needed down the line for other purposes (such as client-side stackwalking).

Comment 1

[Gabriele Svelto [:gsvelto]]

Attachment: Bug 1793784 - Replace the minidump_writer_linux crate with the minidump-writer crate r=glandium

Comment 2

[Gabriele Svelto [:gsvelto]]

Attachment: WIP: Bug 1793784 - Adapt the C/C++ wrapper for the minidump writer to use the new crate

Depends on D158669

Comment 3

[Gabriele Svelto [:gsvelto]]

Attachment: WIP: Bug 1793784 - Audits

Depends on D161134

Comment 4

[Gabriele Svelto [:gsvelto]]

Now that all the dependencies have landed I've rebased my patch and I'm testing it. If all goes well I'll land it later today.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/404e1b833ec6
Replace the minidump_writer_linux crate with the minidump-writer crate r=glandium,supply-chain-reviewers

Comment 6

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/404e1b833ec6