1793853 - [wpt-sync] Sync PR 36298 - [FlexNG] OOF static position when CB is outside multicol

Status: RESOLVED FIXED

(Core :: Layout, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 36298 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/36298
Details from upstream follow.

Alison Maher <[e-mail]> wrote:

[FlexNG] OOF static position when CB is outside multicol

The static position of OOFs in a fragmented flex container are
determined within the last fragment. If the OOF's CB lives outside the
associated multicol, then that static position will be relative to the
last parent fragment and would become negative. Adjust the static
position once it is propagated to the multicol to account for the
potential negative offset (only if the OOF hasn't found its CB yet).

Note that external\wpt\css\css-break\flexbox
flex-container-fragmentation-011.html is not working as expected. The
main reason being that the offset will get adjusted once we know the
OOF's block size in this case, which happens after we've adjusted to
account for any negative block offset.

This solution likely won't work if there is nested fragmentation
involved, such that the multicol/flex container involved are both
fragmented.

This problem applies to grid, as well, but this will be handled in a
separate CL.

Bug: 1367912
Change-Id: I0f0171d50aee4e0c2f582047620a3ac9e7b35fd3
Reviewed-on: https://chromium-review.googlesource.com/3927797
WPT-Export-Revision: 0d7f69ed4b7498a0250ead8a5a2476bc679166fd

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=94ff386a6646d669043e66ddcc3b84f5c9d3dc9e

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 4 tests

Status Summary

Firefox

PASS: 2
FAIL: 2

Chrome

PASS: 1
FAIL: 3

Safari

PASS: 1
FAIL: 3

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /css/css-break/flexbox/flex-container-fragmentation-010.html [wpt.fyi]: FAIL (Chrome: PASS, Safari: FAIL)
• /css/css-break/flexbox/flex-container-fragmentation-011.html [wpt.fyi]: FAIL (Chrome: FAIL, Safari: FAIL)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3622f6db6e4c
[wpt PR 36298] - [FlexNG] OOF static position when CB is outside multicol, a=testonly
https://hg.mozilla.org/integration/autoland/rev/7ce485430333
[wpt PR 36298] - Update wpt metadata, a=testonly

Comment 4

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/3622f6db6e4c
https://hg.mozilla.org/mozilla-central/rev/7ce485430333