1793941 - [CTW] Don't fire EVENT_TABLE_STYLING_CHANGED when the cache is enabled

Status: RESOLVED FIXED

(Core :: Disability Access APIs, task, P3)

Description

[James Teh [:Jamie]]

Even after bug 1726124, I'm still seeing this firing of EVENT_TABLE_STYLING_CHANGED in PruneOrInsertSubtree showing up significantly in profiles when loading large Searchfox pages. The performance is a great deal better, but nevertheless, we're still spending quite a bit of time (over a second in one profile I saw) in CoalesceEvents as a result of this. I guess the event queue must be large enough that this causes issues.

As I understand it, with the cache enabled, we don't need this event any more, as we cache the layout guess in the RemoteAccessible cache. The Mac code probably needs to be updated to handle this, though.

Comment 1

[Morgan Reschenberg [:morgan]]

:Jamie what's your milestone/priority opinion on this?

Comment 2

[James Teh [:Jamie]]

At this stage, I've only seen this in profiles for large Searchfox pages, which is a fairly minor use case in the grand scheme of things. Unless that changes, this is definitely not m3, probably not even m4.

Comment 3

[James Teh [:Jamie]]

Assigning to you, Morgan, as I believe you said you had a local WIP. Please feel free to disown this for now if I was hallucinating.

Comment 4

[Morgan Reschenberg [:morgan]]

Attachment: Bug 1793941: Don't fire EVENT_TABLE_STYLING_CHANGED when the cache is enabled r?Jamie,eeejay

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f5ee2900f8e3
Don't fire EVENT_TABLE_STYLING_CHANGED when the cache is enabled r=Jamie

Comment 6

[Sandor Molnar[:smolnar]]

Backed out for causing mochitest failures in accessible/tests/mochitest/events/test_stylechange.html

Backout link: https://hg.mozilla.org/integration/autoland/rev/eea71e9453fd2959111c38f508ddb0203a47a4a0

Push with failures

Failure log

INFO - TEST-UNEXPECTED-FAIL | accessible/tests/mochitest/events/test_stylechange.html | Test timed out. - 
[task 2023-01-11T18:19:19.771Z] 18:19:19     INFO - Not taking screenshot here: see the one that was previously logged
[task 2023-01-11T18:19:19.771Z] 18:19:19     INFO - TEST-UNEXPECTED-FAIL | accessible/tests/mochitest/events/test_stylechange.html | [SimpleTest.finish()] No checks actually run. (You need to call ok(), is(), or similar functions at least once.  Make sure you use SimpleTest.waitForExplicitFinish() if you need it.) 
[task 2023-01-11T18:19:19.771Z] 18:19:19     INFO - SimpleTest.ok@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:404:16

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2343b6a2e6aa
Don't fire EVENT_TABLE_STYLING_CHANGED when the cache is enabled r=Jamie

Comment 8

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/2343b6a2e6aa