1793959 - Code generation for method decorators

Status: RESOLVED FIXED

(Core :: JavaScript Engine, enhancement, P2)

Description

[Dan Minor [:dminor]]

Code generation for decorators is likely to be complicated, so we'll split it into multiple bugs. This bug covers code generation for method decorators.

Comment 1

[Dan Minor [:dminor]]

Attachment: Bug 1793959 - Add DecoratorEmitter; r=mgaudet!

This adds a stub DecoratorEmitter to the build system.

Comment 2

[Dan Minor [:dminor]]

Attachment: Bug 1793959 - Add ThrowMsgKind::DecoratorInvalidReturnType; r=mgaudet!

We'll need to be able to throw a TypeError if the decorator returns something
other than a callable or undefined.

Depends on D162139

Comment 3

[Dan Minor [:dminor]]

Attachment: Bug 1793959 - Add DecoratorEmitter::emitDecoratorCall; r=mgaudet!

This is a basic implementation of applying a decorator to a method, leaving
many details to subsequent patches and bugs.

Depends on D162140

Comment 4

[Dan Minor [:dminor]]

Attachment: Bug 1793959 - Implement DecorationState; r=mgaudet!

This implements the DecorationState object. It is used with the addInitializer
function, which will be implemented in a follow up bug.

Depends on D162141

Comment 5

[Dan Minor [:dminor]]

Attachment: Bug 1793959 - Implement DecoratorEmitter::emitCreateDecoratorContextObject; r=mgaudet!

This implements the emitter for DecoratorContext objects. The implementations of
the DecoratorAccess object and addInitializer are postponed to follow up bugs.

Depends on D162142

Comment 6

[Dan Minor [:dminor]]

Attachment: Bug 1793959 - Add JSOp::IsCallable; r=mgaudet!

Depends on D162140

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b1336c4324c8
Add DecoratorEmitter; r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/0c77dba9ef46
Add ThrowMsgKind::DecoratorInvalidReturnType; r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/55eb595186b8
Add DecoratorEmitter::emitDecoratorCall; r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/92f6495bff44
Implement DecoratorEmitter::emitCreateDecoratorContextObject; r=mgaudet

Comment 8

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/b1336c4324c8
https://hg.mozilla.org/mozilla-central/rev/0c77dba9ef46
https://hg.mozilla.org/mozilla-central/rev/55eb595186b8
https://hg.mozilla.org/mozilla-central/rev/92f6495bff44