1794020 - Show Pocket tiles in the 2nd spot of sponsored top sites on the newtab page

Status: VERIFIED FIXED

(Firefox :: New Tab Page, task)

Description

[Nan Jiang [:nanj]]

By contract, we will need to ensure that Pocket sponsored tiles are always placed in the 2nd spot of sponsored top sites even if there are no sponsored tiles available from other partners.

Comment 1

[Scott [:thecount] Downe]

Attachment: Bug 1794020 - topsite promo tiles

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ad5bb5f4a576
topsite promo tiles r=nanj

Comment 3

[Marian-Vasile Laza]

Backed out changeset ad5bb5f4a576 (Bug 1794020) for causing bc failures on browser_policy_firefoxhome.js.
Backout link
Push with failures <--> bc2
Failure Log
Also bc1 Failure Log
Also bc5 Failure Log
Also c Failure Log
Also bc9 Failure Log

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/12a565036b3c
topsite promo tiles r=nanj

Comment 5

[Noemi Erli[:noemi_erli]]

Backed out changeset 12a565036b3c (Bug 1794020) for causing DiscoveryStreamFeed.jsm related failures CLOSED TREE

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&collapsedPushes=842382&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=12a565036b3ce4b7ab38b87d3ef31d50d60bee8b&selectedTaskRun=MKrTGsW6T5yKtOf0dhLHkw.0

Log: https://treeherder.mozilla.org/logviewer?job_id=394617302&repo=autoland&lineNumber=16129

Backout: https://hg.mozilla.org/integration/autoland/rev/57e939766b3017c159b55af1818eb53cff484471

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/19fcc2a044a8
topsite promo tiles r=nanj

Comment 7

[Sandor Molnar[:smolnar]]

Backed out for causing mochitest failures in lib/DiscoveryStreamFeed.jsm

Backout link: https://hg.mozilla.org/integration/autoland/rev/c81db1897f51c925894c5035fe03a53b652cce1e

Push with failures

Failure log

INFO - TEST-START | browser/components/extensions/test/browser/browser_ExtensionControlledPopup.js
[task 2022-10-28T18:30:00.899Z] 18:30:00     INFO - GECKO(1625) | [Parent 1625, Main Thread] WARNING: NS_ENSURE_TRUE(aPrefName) failed: file /builds/worker/checkouts/gecko/modules/libpref/Preferences.cpp:2289
[task 2022-10-28T18:30:00.907Z] 18:30:00     INFO - GECKO(1625) | [Parent 1625, Main Thread] WARNING: NS_ENSURE_TRUE(aPrefName) failed: file /builds/worker/checkouts/gecko/modules/libpref/Preferences.cpp:2289
[task 2022-10-28T18:30:01.195Z] 18:30:01     INFO - GECKO(1625) | FATAL ERROR: Non-local network connections are disabled and a connection attempt to spocs.getpocket.com (50.16.147.46) was made.
[task 2022-10-28T18:30:01.199Z] 18:30:01     INFO - GECKO(1625) | You should only access hostnames available via the test networking proxy (if running mochitests) or from a test-specific httpd.js server (if running xpcshell tests). Browser services should be disabled or redirected to a local server.
[task 2022-10-28T18:30:01.201Z] 18:30:01     INFO - GECKO(1625) | FATAL ERROR: Non-local network connections are disabled and a connection attempt to spocs.getpocket.com (50.16.147.46) was made.
[task 2022-10-28T18:30:01.201Z] 18:30:01     INFO - GECKO(1625) | You should only access hostnames available via the test networking proxy (if running mochitests) or from a test-specific httpd.js server (if running xpcshell tests). Browser services should be disabled or redirected to a local server.
[task 2022-10-28T18:30:01.221Z] 18:30:01     INFO - GECKO(1625) | Hit MOZ_CRASH(Attempting to connect to non-local address! opener is [resource://activity-stream/lib/DiscoveryStreamFeed.jsm:396:32], uri is [https://spocs.getpocket.com/user]) at /builds/worker/checkouts/gecko/netwerk/protocol/http/nsHttpChannel.cpp:6939
[task 2022-10-28T18:30:01.242Z] 18:30:01     INFO -  Initializing stack-fixing for the first stack frame, this may take a while...
[task 2022-10-28T18:30:12.850Z] 18:30:12     INFO - GECKO(1625) | #01: mozilla::net::nsHttpChannel::OnStartRequest(nsIRequest*) [netwerk/protocol/http/nsHttpChannel.cpp:6932]

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f394d8fa64f3
topsite promo tiles r=nanj

Comment 9

[Marian-Vasile Laza]

Backed out changeset f394d8fa64f3 (Bug 1794020) for causing marionette & telemetry failures.
Backout link
Push with failures <--> Mn <--> c
Mn Failure Log
c Failure Log

Comment 10

[Scott [:thecount] Downe]

Attachment: Bug 1794020 - topsite promo tiles

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e7a66f866e88
topsite promo tiles

Comment 12

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/e7a66f866e88

Comment 13

[Cosmin Muntean [:cmuntean], Ecosystem QA]

I have verified this issue on the latest Nightly 108.0a1 (Build ID: 20221109164728) on Windows 10 x64, macOS 12.4 and Linux Mint 20 x64.

• The Sponsored tile via Pocket is always displayed on the second position.