Closed Bug 1794188 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 36174 - [css-flex] Fix column-wrap container max < min error with % width item

Categories

(Core :: Layout: Flexbox, task, P4)

Product:
Core
Component:
Layout: Flexbox
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
108 Branch
Tracking Flags:
Tracking Status
firefox108 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 36174 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/36174
Details from upstream follow.

David Grogan <dgrogan@chromium.org> wrote:

[css-flex] Fix column-wrap container max < min error with % width item

When laying out items during column-wrap container max intrinsic sizing,
items with % width were resolving against indefinite, so contributed 0
width.

But during intrinsic sizing, children with % width are supposed to treat
that width as auto, which ComputeMinMaxContributionSizes already
handles.

So instead of letting items resolve their widths during layout during
intrinsic sizing, fix items' inline sizes to the their max contribution
size in the various constraint spaces.

Bug: 240765
Change-Id: I8aa16497e759cb6325f6febcab3446328abf9002
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3927803
Reviewed-by: Ian Kilpatrick \<ikilpatrick@chromium.org>
Commit-Queue: David Grogan \<dgrogan@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1056008}

Component: web-platform-tests → Layout: Flexbox
Product: Testing → Core

CI Results

Ran 10 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 10 tests and 1 subtests

Status Summary

Firefox

OK : 3
PASS: 2[Gecko-android-em-7.0-x86_64-qr-debug-isolated-process-geckoview] 7[Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-32-2004-qr-debug, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt, GitHub]
FAIL: 1[Gecko-android-em-7.0-x86_64-qr-debug-isolated-process-geckoview] 3[Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-32-2004-qr-debug, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt, GitHub]

Chrome

OK : 3
PASS: 7
FAIL: 3

Safari

OK : 3
PASS: 7
FAIL: 3

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/32d7198a1a13 [wpt PR 36174] - [css-flex] Fix column-wrap container max < min error with % width item, a=testonly https://hg.mozilla.org/integration/autoland/rev/1b4f44f3ea3e [wpt PR 36174] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/32d7198a1a13
https://hg.mozilla.org/mozilla-central/rev/1b4f44f3ea3e

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox108: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 108 Branch
You need to log in before you can comment on or make changes to this bug.