Closed Bug 1794191 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 36340 - Rename show->popupshow, hide->popuphide, and add global handlers

Categories

(Core :: DOM: Core & HTML, task, P4)

Product:
Core
Component:
DOM: Core & HTML
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
108 Branch
Tracking Flags:
Tracking Status
firefox108 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Attachments

(8 files)

Notable wpt changes
160.81 KB, text/plain
Details
Notable wpt changes
160.81 KB, text/plain
Details
Notable wpt changes
160.81 KB, text/plain
Details
Notable wpt changes
160.81 KB, text/plain
Details
Notable wpt changes
160.81 KB, text/plain
Details
Notable wpt changes
160.81 KB, text/plain
Details
Notable wpt changes
160.81 KB, text/plain
Details
Notable wpt changes
160.81 KB, text/plain
Details

Sync web-platform-tests PR 36340 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/36340
Details from upstream follow.

Mason Freed <masonf@chromium.org> wrote:

Rename show->popupshow, hide->popuphide, and add global handlers

Per [1], there's feedback that "show" and "hide" are too generic
and could be confusing. Developers might think anything that shows
or hides (e.g. via display:none) should fire these events. So this
CL renames them to "popupshow" and "popuphide". It also adds global
event handlers, behind the flag.

[1] https://github.com/openui/open-ui/issues/607#issuecomment-1270733378

Bug: 1307772
Change-Id: Iaec1306176e7e08dc367c25b801d6b21f19a1f88
Reviewed-on: https://chromium-review.googlesource.com/3938538
WPT-Export-Revision: 5c2da4cf3034b75f3c63417f742cb3bff684ea3b

Component: web-platform-tests → DOM: Core & HTML
Product: Testing → Core
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Attached file Notable wpt changes —
# CI Results Ran 10 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI Total 6 tests and 1 subtests ## Status Summary ### Firefox `OK` : 5 `FAIL` : 1430 `ERROR`: 1 ### Chrome `OK` : 6 `PASS` : 1422 `FAIL` : 10 ### Safari `OK` : 5 `FAIL` : 1430 `ERROR`: 1 ## Links [Gecko CI (Treeherder)](https://treeherder.mozilla.org/#/jobs?repo=try&revision=78f65ab5c110df8d0a99533586c5bc84e287f0ba) [GitHub PR Head](https://wpt.fyi/results/?sha=0e16224d8ce8458cd69df5ae6eb3c476d8dcdff7&label=pr_head) [GitHub PR Base](https://wpt.fyi/results/?sha=0e16224d8ce8458cd69df5ae6eb3c476d8dcdff7&label=pr_base) ## Details (See attachment for full changes)
Attached file Notable wpt changes —
# CI Results Ran 10 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI Total 6 tests and 1 subtests ## Status Summary ### Firefox `OK` : 5 `FAIL` : 1430 `ERROR`: 1 ### Chrome `OK` : 6 `PASS` : 1422 `FAIL` : 10 ### Safari `OK` : 5 `FAIL` : 1430 `ERROR`: 1 ## Links [Gecko CI (Treeherder)](https://treeherder.mozilla.org/#/jobs?repo=try&revision=78f65ab5c110df8d0a99533586c5bc84e287f0ba) [GitHub PR Head](https://wpt.fyi/results/?sha=0e16224d8ce8458cd69df5ae6eb3c476d8dcdff7&label=pr_head) [GitHub PR Base](https://wpt.fyi/results/?sha=0e16224d8ce8458cd69df5ae6eb3c476d8dcdff7&label=pr_base) ## Details (See attachment for full changes)
Attached file Notable wpt changes —
# CI Results Ran 10 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI Total 6 tests and 1 subtests ## Status Summary ### Firefox `OK` : 5 `FAIL` : 1430 `ERROR`: 1 ### Chrome `OK` : 6 `PASS` : 1422 `FAIL` : 10 ### Safari `OK` : 5 `FAIL` : 1430 `ERROR`: 1 ## Links [Gecko CI (Treeherder)](https://treeherder.mozilla.org/#/jobs?repo=try&revision=78f65ab5c110df8d0a99533586c5bc84e287f0ba) [GitHub PR Head](https://wpt.fyi/results/?sha=0e16224d8ce8458cd69df5ae6eb3c476d8dcdff7&label=pr_head) [GitHub PR Base](https://wpt.fyi/results/?sha=0e16224d8ce8458cd69df5ae6eb3c476d8dcdff7&label=pr_base) ## Details (See attachment for full changes)
Attached file Notable wpt changes —
# CI Results Ran 10 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI Total 6 tests and 1 subtests ## Status Summary ### Firefox `OK` : 5 `FAIL` : 1430 `ERROR`: 1 ### Chrome `OK` : 6 `PASS` : 1422 `FAIL` : 10 ### Safari `OK` : 5 `FAIL` : 1430 `ERROR`: 1 ## Links [Gecko CI (Treeherder)](https://treeherder.mozilla.org/#/jobs?repo=try&revision=78f65ab5c110df8d0a99533586c5bc84e287f0ba) [GitHub PR Head](https://wpt.fyi/results/?sha=0e16224d8ce8458cd69df5ae6eb3c476d8dcdff7&label=pr_head) [GitHub PR Base](https://wpt.fyi/results/?sha=0e16224d8ce8458cd69df5ae6eb3c476d8dcdff7&label=pr_base) ## Details (See attachment for full changes)
Attached file Notable wpt changes —
# CI Results Ran 10 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI Total 6 tests and 1 subtests ## Status Summary ### Firefox `OK` : 5 `FAIL` : 1430 `ERROR`: 1 ### Chrome `OK` : 6 `PASS` : 1422 `FAIL` : 10 ### Safari `OK` : 5 `FAIL` : 1430 `ERROR`: 1 ## Links [Gecko CI (Treeherder)](https://treeherder.mozilla.org/#/jobs?repo=try&revision=78f65ab5c110df8d0a99533586c5bc84e287f0ba) [GitHub PR Head](https://wpt.fyi/results/?sha=0e16224d8ce8458cd69df5ae6eb3c476d8dcdff7&label=pr_head) [GitHub PR Base](https://wpt.fyi/results/?sha=0e16224d8ce8458cd69df5ae6eb3c476d8dcdff7&label=pr_base) ## Details (See attachment for full changes)
Attached file Notable wpt changes —
# CI Results Ran 10 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI Total 6 tests and 1 subtests ## Status Summary ### Firefox `OK` : 5 `FAIL` : 1430 `ERROR`: 1 ### Chrome `OK` : 6 `PASS` : 1422 `FAIL` : 10 ### Safari `OK` : 5 `FAIL` : 1430 `ERROR`: 1 ## Links [Gecko CI (Treeherder)](https://treeherder.mozilla.org/#/jobs?repo=try&revision=78f65ab5c110df8d0a99533586c5bc84e287f0ba) [GitHub PR Head](https://wpt.fyi/results/?sha=0e16224d8ce8458cd69df5ae6eb3c476d8dcdff7&label=pr_head) [GitHub PR Base](https://wpt.fyi/results/?sha=0e16224d8ce8458cd69df5ae6eb3c476d8dcdff7&label=pr_base) ## Details (See attachment for full changes)
Attached file Notable wpt changes —
# CI Results Ran 10 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI Total 6 tests and 1 subtests ## Status Summary ### Firefox `OK` : 5 `FAIL` : 1430 `ERROR`: 1 ### Chrome `OK` : 6 `PASS` : 1422 `FAIL` : 10 ### Safari `OK` : 5 `FAIL` : 1430 `ERROR`: 1 ## Links [Gecko CI (Treeherder)](https://treeherder.mozilla.org/#/jobs?repo=try&revision=78f65ab5c110df8d0a99533586c5bc84e287f0ba) [GitHub PR Head](https://wpt.fyi/results/?sha=0e16224d8ce8458cd69df5ae6eb3c476d8dcdff7&label=pr_head) [GitHub PR Base](https://wpt.fyi/results/?sha=0e16224d8ce8458cd69df5ae6eb3c476d8dcdff7&label=pr_base) ## Details (See attachment for full changes)
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/04249cf0c5c8 [wpt PR 36340] - Rename show->popupshow, hide->popuphide, and add global handlers, a=testonly https://hg.mozilla.org/integration/autoland/rev/8bd2dbf199d5 [wpt PR 36340] - Update wpt metadata, a=testonly
Attached file Notable wpt changes —
# CI Results Ran 10 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI Total 6 tests and 1 subtests ## Status Summary ### Firefox `OK` : 5 `FAIL` : 1430 `ERROR`: 1 ### Chrome `OK` : 6 `PASS` : 1422 `FAIL` : 10 ### Safari `OK` : 5 `FAIL` : 1430 `ERROR`: 1 ## Links [Gecko CI (Treeherder)](https://treeherder.mozilla.org/#/jobs?repo=try&revision=78f65ab5c110df8d0a99533586c5bc84e287f0ba) [GitHub PR Head](https://wpt.fyi/results/?sha=0e16224d8ce8458cd69df5ae6eb3c476d8dcdff7&label=pr_head) [GitHub PR Base](https://wpt.fyi/results/?sha=0e16224d8ce8458cd69df5ae6eb3c476d8dcdff7&label=pr_base) ## Details (See attachment for full changes)
Test result changes from PR not available.

https://hg.mozilla.org/mozilla-central/rev/04249cf0c5c8
https://hg.mozilla.org/mozilla-central/rev/8bd2dbf199d5

Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox108: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 108 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: