Closed Bug 1794239 Opened 2 years ago Closed 2 years ago

Filename errors cause save fails

Categories

(Firefox :: File Handling, defect)

Firefox 106
defect

Tracking

()

RESOLVED DUPLICATE of bug 1794238

People

(Reporter: uiy12345, Unassigned)

Details

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:106.0) Gecko/20100101 Firefox/106.0

Steps to reproduce:

When firefox suggests a filename from the title of a page or whatever when using "save page as" and "take screenshot" it sometimes generates bogus names in windows due to either length errors or unsupported characters. This is quite annoying as sometimes it can cause problems with forgetting to retry the download and fix the filename(and knowing exactly what is in error).

I save a lot of reddit pages and they end to have lots of ascii that isn't supported by windows or the names are very long(snapshot seems to truncate them sometimes).

Actual results:

Wont' save due to invalid filenames

Expected results:

It should just work.

I think going through the code that fixes up the names and

  1. Replacing invalid chars with unicode equivalents that work. E.g., replace the colons, pounds, slashs, quotes, etc.

  2. Making sure the length is not too long that causes save error.

Hi uiy12345, can you please share one of the links that is causing this issue so we can try to reproduce it on our side as well ?

Component: Untriaged → File Handling
Flags: needinfo?(uiy12345)

This issue seems to be caused by the same thing as Bug 1794238, I will close this one and keep the work tracked in that issue.

Status: UNCONFIRMED → RESOLVED
Closed: 2 years ago
Resolution: --- → DUPLICATE
Flags: needinfo?(uiy12345)
You need to log in before you can comment on or make changes to this bug.