1794261 - "Get recent tabs back with firefox view" message appearing too many times

Status: VERIFIED FIXED

(Firefox :: Messaging System, enhancement, P1)

Description

[zlice]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:107.0) Gecko/20100101 Firefox/107.0

Steps to reproduce:

Nightly has been running great over the summer, but there is something I would like to disable (not really a bug). Can't get a screenshot because as soon as you do any input it seems to disappear.

Close a tab

Actual results:

Sometimes there's an annoying pop-up over the https lockk and pref icon on the left of the address bar - "get recent tabs back with firefox view"

Expected results:

I would like to disable this.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Firefox::Address Bar' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[Vlad Lucaci, Thunderbird QA (:vlucaci)]

I think this belongs in FF View component.

Comment 3

[Rares Doghi, Desktop QA]

This could be a great enhancement, most users would like to disable any pop-ups displayed.

Comment 4

[Ray Fambro]

Sounds like this might be a Messaging component @vtay?

Comment 5

[:Gijs (he/him)]

(In reply to Ray Fambro from comment #4)

Sounds like this might be a Messaging component @vtay?

I think so - this is the onboarding stuff. I would have expected this to not display more than N times for some reasonable N, but I'm not familiar with what logic is being used.

Comment 6

[Ed Lee :Mardak]

The message has a lifetime frequency cap of 1, so it should only show once. Additionally, it checks for browser.firefox-view.view-count equal to 0. Have you never opened Firefox view? Do you clean up your Firefox profile, e.g., removing prefs or other local storage?

Comment 7

[Vtay]

As mentioned, you should be seeing it only 1x (unless you are using multiple profiles/machines etc). Also. in about:preferences, we have an option for users to deselect "Recommend features as you browse" which disables messages.

Comment 8

[zlice]

toggling remote.prefs.recommended to false to see. it has definentely came up more than once, not sure if that's only across nightly updates or not though.

i believe browser.firefox-view.view-count is getting reset because i have a pref cfg that loads for ease of setting up my profile since it's a pain to do and debug nightly issues. can try making that 1

Comment 9

[Punam Dahiya [:pdahiya]]

CFR has group set https://searchfox.org/mozilla-central/source/browser/components/newtab/lib/OnboardingMessageProvider.jsm#86 that can be used to remotely update the message group "cfr" userPreferences to check for “recommended features” pref browser.newtabpage.activity-stream.asrouter.userprefs.cfr.features which will allow users to uncheck 'Recommend features as you browse' in about:preferences to turn off FirefoxView CFR

https://github.com/mozilla/messaging-system-inflight-assets/blob/master/messages/message-groups.yaml

This can be done off-train via Remote Settings

Comment 10

[Punam Dahiya [:pdahiya]]

https://bugzilla.mozilla.org/show_bug.cgi?id=1794851 is tracking fix explained in #comment 9

Comment 11

[Punam Dahiya [:pdahiya]]

Hi @zlice, following up if changing pref 'browser.firefox-view.view-count' to 1 helped hide the message?

To help debug the issue can you please share the impression count of the "Get recent tabs back with firefox view" message. You can see it in devtools by following below steps

a) Set pref 'browser.newtabpage.activity-stream.asrouter.devtoolsEnabled' to true in about:config
b) Open about:newtab#devtools
c) Search for “CFR_FIREFOX_VIEW” , it should have impressions count respective to message ( See attached screenshot where CFR_FIREFOX_VIEW has 0 impressions)

Also, it will help if you can share details on what steps you follow as part of clean up of Firefox profile, does it involve removing prefs and browser local storage? Thanks!

Comment 12

[Punam Dahiya [:pdahiya]]

Attachment: CFR_FIREFOX_VIEW with zero impressions

Comment 13

[zlice]

fyi - have to enable browser.newtabpage.enabled (usually have this off)

It says 0 upon browser startup. I haven't seen the OP pop-up since changing my settings but I also haven't been online much the past couple days.

Comment 14

[Punam Dahiya [:pdahiya]]

Thanks for confirming, that's correct to access newtab and devtools content you need browser.newtabpage.enabled set to true. With browser.firefox-view.view-count set as 1 if you aren't seeing message it shows targeting is working as expected.

Ideally this message should be seen only once i.e till one impression is recorded even if browser.firefox-view.view-count is 0. You can leave pref value browser.firefox-view.view-count as 0 and if you see message more than once again in Nightly, to help debug impression flow, will be great if you can update bug with impression count from about:newtab#devtools.

Comment 15

[zlice]

It looks like those settings have prevented the pop-up over the past few days. Thanks all.

Comment 16

[Ed Lee :Mardak]

Fixed with bug 1795037
https://hg.mozilla.org/mozilla-central/rev/e22a388668c5

Comment 17

[Ed Lee :Mardak]

https://hg.mozilla.org/releases/mozilla-beta/rev/3cc8427ca4fb

Comment 18

[Rares Doghi, Desktop QA]

This issue is Verified as fixed based on Comment 15 and the fact that the pop up no longer shows up more than once. I will updated the flags for this issue.