1794306 - thunderbird LDAP search queries contains cyrillic letters doesn't work

Status: RESOLVED FIXED

(MailNews Core :: Address Book, defect)

Description

[Rail]

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux i686; rv:88.0) Gecko/20100101 Firefox/88.0

Steps to reproduce:

I edit the search filter, for example like this:
(&(objectClass=)(l=Ереван))
Then I save the settings

Actual results:

After that search don't work and edit filter shows like:
(&(objectClass=)(l=%D0%95%D1%80%D0%B5%D0%B2%D0%B0%D0%BD))
In prefs.js letters displayed correctly

Expected results:

Working LDAP search with filters in address-books

Comment 1

[Rail]

Attachment: ldap.png

Comment 2

[Ping Chen [:rnons] (away)]

Attachment: Bug 1794306 - Decode ldap search filter to support non-ascii characters. r=benc

Non-ascii characters in ldap filter are percent encoded when saving, need to decode when constructing nsILDAPURL back.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/f8c45af1115f
Decode ldap search filter to support non-ascii characters. r=benc

Comment 4

[Ping Chen [:rnons] (away)]

Comment on attachment 9297917 [details]
Bug 1794306 - Decode ldap search filter to support non-ascii characters. r=benc

[Approval Request Comment]
Regression caused by (bug #): bug 1729862
User impact if declined: LDAP doesn't work if custom search filter contains non-ascii characters
Testing completed (on c-c, etc.): beta
Risk to taking this patch (and alternatives if risky): low

Comment 5

[Wayne Mery (:wsmwk)]

Comment on attachment 9297917 [details]
Bug 1794306 - Decode ldap search filter to support non-ascii characters. r=benc

[Triage Comment]
Approved for esr102

Comment 6

[Rob Lemley [:rjl]]

Thunderbird 102.4.2:
https://hg.mozilla.org/releases/comm-esr102/rev/9ac38ce84f08