1794441 - Add WPT tests for full ASCII set and non-ASCII chars for OPFS filenames

Status: RESOLVED FIXED

(Core :: DOM: File, enhancement)

Description

[Randell Jesup [:jesup] (needinfo me)]

Must exclude '/' per the spec. Assumes that the "platform-specific file separators" bit will be removed from the spec (so we can use '' on all platforms). We don't include the non-printable characters from ASCII (values <32 except for LF/CR/FF/TAB/VT, and exclude DEL) since those won't convert to JS chars.

Comment 1

[Randell Jesup [:jesup] (needinfo me)]

Attachment: Bug 1794441: Add wpt tests for every ASCII character and for non-ASCII characters r=#dom-storage-reviewers

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:jesup, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit auto_nag documentation.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/934279c489b2
Add wpt tests for every ASCII character and for non-ASCII characters r=dom-storage-reviewers,jari

Comment 4

[Cristian Tuns]

Backed out for causing wpt failures on FileSystemDirectoryHandle-getFileHandle.https.any.html

• Backout link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | /fs/FileSystemDirectoryHandle-getFileHandle.https.any.html | getFileHandle(create=true) creates an empty file with all valid ASCII characters in the name - promise_test: Unhandled rejection with value: object "TypeError: Invalid filename"

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/196179e9bedf
Add wpt tests for every ASCII character and for non-ASCII characters r=dom-storage-reviewers,jari

Comment 6

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/37384 for changes under testing/web-platform/tests

Comment 7

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/196179e9bedf

Comment 8

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot