17945 - non-proper concatenation in wallet.properties

Status: VERIFIED FIXED

(Toolkit :: Form Manager, defect, P3)

Description

[rchen]

In wallet.properties, there are two concatenation. The first letter of the
first word of the second string is separated to the end of the first string.
Please see 'Y' at the end of PasswordNotification1 and 'T' at the end of
WalletNotification1:

PasswordNotification1 = For your convenience, the browser can remember your user
names and passwords so you won't have to re-type them in the future.  Y
PasswordNotification2 = our passwords will be obscured before being saved on
your hard drive.  Do you want this feature enabled?

WalletNotification1 = You can save information that you enter on forms and later
automatically prefill that information on other forms.  T
WalletNotification2 = o save such information, select edit/wallet/capture from
the menu while viewing the form.

Steve, if you want to put the space between the two strings, please do it in the
code level not in the resource level. This confuses translator and causes a
problem for translation tool.  Thanks.

Comment 1

[Stephen P. Morse]

Have fix.  Awaiting code review from rchen before checking in.

Comment 2

[Stephen P. Morse]

Fix checked in.  Consists of new versions of wallet.cpp, singsign.cpp, and
wallet.properties.  Reviewed by Erik van der Poel.

Comment 3

[rchen]

verified