Closed Bug 1794503 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 36386 - [FlexNG] RelayoutAndBreakEarlier stack overflow

Categories

(Core :: Layout, task, P4)

Product:
Core
Component:
Layout
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
108 Branch
Tracking Flags:
Tracking Status
firefox108 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 36386 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/36386
Details from upstream follow.

Alison Maher <almaher@microsoft.com> wrote:

[FlexNG] RelayoutAndBreakEarlier stack overflow

Similar to CL:3582397, if we RelayoutIgnoringChildScrollbarChanges()
and then RelayoutAndBreakEarlier(), we would hit a stack overflow
because RelayoutAndBreakEarlier() doesn't set
ignore_child_scrollbar_changes_ (which leads us to alternate between
the two relayouts infinitely).

To fix this, create a new RelayoutAndBreakEarlier() overload in
NGLayoutAlgorithm that takes and Algorithm as input. This allows us
to pass in an Algorithm to RelayoutAndBreakEarlier() from
NGFlexLayoutAlgorithm that sets ignore_child_scrollbar_changes_
correctly.

Bug: 1370404
Change-Id: I9a98749d30e55cdc2aad3c8e001e2e226354b509

Reviewed-on: https://chromium-review.googlesource.com/3942358
WPT-Export-Revision: 0083ae32b83548b2819b02ed7d393ea99b28cfd6

Component: web-platform-tests → Layout
Product: Testing → Core
The PR was not expected to affect any tests, but the try push wasn't a success. Check the try results for infrastructure issues
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b64e04723c69 [wpt PR 36386] - [FlexNG] RelayoutAndBreakEarlier stack overflow, a=testonly
Test result changes from PR not available.

https://hg.mozilla.org/mozilla-central/rev/b64e04723c69

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox108: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 108 Branch
You need to log in before you can comment on or make changes to this bug.