1794504 - The unified extensions menu's permissions notes aren't specific enough and sound contradictory when changing from "Can always read and change data" to "Can't...for this site"

Status: RESOLVED FIXED

(WebExtensions :: General, defect)

Description

[Daniel Holbert [:dholbert]]

STR:

1. Set about:config pref extensions.unifiedExtensions.enabled to true and restart Firefox:
2. Install these add-ons:
   https://addons.mozilla.org/en-US/firefox/addon/multi-account-containers/
   https://addons.mozilla.org/en-US/firefox/addon/enhancer-for-youtube/
   (The first is enabled globally; the second is only active on YouTube).
3. Visit a few sites and see what the Unified Extensions Button's menu shows for your extensions:

• https://www.youtube.com
• https://example.org
• about:newtab

EXPECTED RESULTS:
Consistent/understandable messaging.

ACTUAL RESULTS:

• At YouTube, the menu reports that both extensions "Can always read and change data"
• At example.org, the menu reports that Enhancer for YouTube "Can't read and change data on this site"
• At about:newtab, the menu reports for both extensions "Can't read and change data on this site"

The ACTUAL RESULTS are confusing because in the "can always read and change data" message, the word "always" sounds like it means "always/everywhere". So it's weird to see that message for a site-specific add-on like Enhancer for YouTube, where a user only expects it to affect a certain site. And it's also weird to see the messaging change from the universal "Can always..." to "Can't".

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: screencast showing the various messages changing ("Can always" turning into "Can't...for this site")

Comment 2

[William Durand [:willdurand]]

Attachment: Bug 1794504 - Fix a localized string. r?zombie!

I didn't version the string because this is still a "preview" file.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ff0e907e474b
Fix a localized string. r=zombie

Comment 4

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/ff0e907e474b