1794551 - nsCookieBannerService.cpp:137:7: error: ‘NS_NewRunnableFunction’ was not declared in this scope

Status: RESOLVED FIXED

(Firefox :: Untriaged, defect)

Description

[Petr Sumbera]

Steps to reproduce:

Solaris build fails with:

20:06.24 /builds/psumbera/mozilla-central-build/toolkit/components/cookiebanners/nsCookieBannerService.cpp: In member function ‘nsresult mozilla::nsCookieBannerService::Init()’:
20:06.24 /builds/psumbera/mozilla-central-build/toolkit/components/cookiebanners/nsCookieBannerService.cpp:137:7: error: ‘NS_NewRunnableFunction’ was not declared in this scope
20:06.24   137 |       NS_NewRunnableFunction("CookieBannerListService init startup",
20:06.24       |       ^~~~~~~~~~~~~~~~~~~~~~
20:06.24 /builds/psumbera/mozilla-central-build/toolkit/components/cookiebanners/nsCookieBannerService.cpp:139:27: error: ‘Idle’ is not a member of ‘mozilla::EventQueuePriority’
20:06.24   139 |       EventQueuePriority::Idle);
20:06.24       |                           ^~~~
20:06.30 /builds/psumbera/mozilla-central-build/toolkit/components/cookiebanners/nsCookieBannerService.cpp:136:17: error: ‘NS_DispatchToCurrentThreadQueue’ was not declared in this scope
20:06.30   136 |   nsresult rv = NS_DispatchToCurrentThreadQueue(
20:06.30       |                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

The first bad revision is:
changeset: 637340:de07e2b641d8
user: Paul Zuehlcke <[e-mail]>
date: Mon Oct 10 08:00:26 2022 -0700
description:
Bug 1784868 - Defer CookiebannerListService init to prevent early main-thread IO. r=timhuang

Differential Revision: https://phabricator.services.mozilla.com/D158941

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:pbz, since you are the author of the regressor, bug 1784868, could you take a look? Also, could you set the severity field?

For more information, please visit auto_nag documentation.

Comment 2

[Paul Zühlcke [:pbz]]

Thanks for filing a bug. I don't have a Solaris machine to test this with, but I suspect this just fails because of missing includes. Could you test if it builds properly with the attached patch applied? Thank you!

Comment 3

[Paul Zühlcke [:pbz]]

Attachment: Bug 1794551 - Add missing nsThreadUtils include in nsCookieBannerService.cpp.

Comment 4

[Petr Sumbera]

Yes, the patch file resolves the build issue. Thank you!

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1784868

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cd61d346fe13
Add missing nsThreadUtils include in nsCookieBannerService.cpp. r=timhuang

Comment 7

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/cd61d346fe13